Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASDisplayNode] Propagate traits before loading a subnode #1234

Merged
merged 1 commit into from
Nov 20, 2018

Commits on Nov 14, 2018

  1. [ASDisplayNode] Propagate traits before loading a subnode

    TextureGroup#886 enforces that some nodes are loaded before they are sent a visiblity event, but it was not propagating the trait collection before forcing the load.
    
    We are propagating traits in `_setSupernode:` (which was happening after the forced load). I moved the possible forced load to `_setSupernode:`, after propagating traits but before any visibility states are changed.
    rcancro committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    f24bf80 View commit details
    Browse the repository at this point in the history