Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASTextNode2] Upgrade lock safety by protecting all ivars (including rarely-changed ones). #918

Merged
merged 2 commits into from
May 19, 2018
Merged

[ASTextNode2] Upgrade lock safety by protecting all ivars (including rarely-changed ones). #918

merged 2 commits into from
May 19, 2018

Commits on May 19, 2018

  1. [ASTextNode2] Upgrade lock safety by protecting all ivars (including … 

    …rarely-changed ones).

Although I don't know of any specific crashes caused by this, I think we should
lock all properties by default. There are also some indications of premature
optimization in keeping lock scope small, where it is actually important to
have transactional integrity, and also where the ASDisplayNode base class is
otherwise going to repeatedly re-lock the object anyway.

I think this will remain pretty efficient, especially with os_unfair_lock enabled.
    @appleguy
    appleguy authored and Adlai Holler committed May 19, 2018
    Configuration menu
    Copy the full SHA
    2759f83 View commit details
    Browse the repository at this point in the history

  2. Use compare-assign macros

    Adlai Holler committed May 19, 2018
    Configuration menu
    Copy the full SHA
    767dc5d View commit details
    Browse the repository at this point in the history