[ASTableView] Generate a new cell layout if existing ones are invalid #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t if the existing ones are invalid
|
🚫 CI failed with log |
maicki
reviewed
May 25, 2018
Source/ASTableView.mm
Outdated
| ASCellNode *node = element.node; | ||
| if (element != nil && node != nil) { | ||
| height = [node layoutThatFits:element.constrainedSize].size.height; | ||
| } |
There was a problem hiding this comment.
Do we not need the else case and use the cached size: node.calculatedSize.height;
There was a problem hiding this comment.
No we don't. -layoutThatFits: checks and uses the cached size if possible.
Source/ASTableView.mm
Outdated
| ASCellNode *node = element.node; | ||
| if (element != nil && node != nil) { | ||
| height = [node layoutThatFits:element.constrainedSize].size.height; | ||
| } |
There was a problem hiding this comment.
Should we assert that node exists?
nguyenhuy
changed the title
maicki
approved these changes
May 25, 2018
|
🚫 CI failed with log |
nguyenhuy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.