-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASTableView] Generate a new cell layout if existing ones are invalid #942
Merged
nguyenhuy
merged 6 commits into
TextureGroup:master
from
nguyenhuy:HNTableViewHeightQuery
May 28, 2018
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e78485c
During row height query, ASTableView should generate a new cell layou…
nguyenhuy de8f288
Update CHANGELOG
nguyenhuy f9c6ab8
Assert node not nil
nguyenhuy 444f3ff
Update CHANGELOG
nguyenhuy ebd20cc
Fix failing test
nguyenhuy 6c7564e
Slightly better comment
nguyenhuy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -919,8 +919,14 @@ - (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(N | |
|
||
- (CGFloat)tableView:(UITableView *)tableView heightForRowAtIndexPath:(NSIndexPath *)indexPath | ||
{ | ||
ASCellNode *node = [_dataController.visibleMap elementForItemAtIndexPath:indexPath].node; | ||
CGFloat height = node.calculatedSize.height; | ||
CGFloat height = 0.0; | ||
|
||
ASCollectionElement *element = [_dataController.visibleMap elementForItemAtIndexPath:indexPath]; | ||
if (element != nil) { | ||
ASCellNode *node = element.node; | ||
ASDisplayNodeAssertNotNil(node, @"Node must not be nil!"); | ||
height = [node layoutThatFits:element.constrainedSize].size.height; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we assert that node exists? |
||
|
||
#if TARGET_OS_IOS | ||
/** | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not need the else case and use the cached size:
node.calculatedSize.height;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No we don't.
-layoutThatFits:
checks and uses the cached size if possible.