Refactor main.js, enable custom screensize

[pciavald]

I've extracted most of the electron-related logic into electron.js and grouped together behaviors that were a bit scattered in main.js. The logic is more state based and with the default values for BrowserWindow and state overrides, it was easy to implement custom window properties from the user config.

As an example, we use it with these settings:

{
  "config": {
    octodash": {
      "window": {
        "width": 800,
        "height": 454,
        "y": 26,
        "fullscreen": false
      }
    }
  }
}

x is also exposed and was not included in this example to show how only needed values can be passed.

If you prefer that these are written by default in the config file, i can do it based on what's currently happening. Feel free to close if you don't want it in upstream.

Fixes #1586
Supplements #1627

[pciavald]

needs to be regenerated on your side

[UnchartedBull]

Why was the protocol removed? Was this tested on an actual machine or just in a dev environment?

Please make the newly added config entries required and provide the default values in app.service.ts

[UnchartedBull]

fullscreen should default to true

[UnchartedBull]

numbers would make more sense here i guess.

[UnchartedBull]

defaults should be: 800, 480, 0, 0, since that is the main resolution OctoDash is being developed for.

[UnchartedBull]

please use the OctoDash background-color here (or black)

[UnchartedBull]

I guess it would make sense to merge fetchConfig and readConfig.

[UnchartedBull]

this part should be loaded from the config

[UnchartedBull]

this can be removed if the config properties are required.

[UnchartedBull]

Just had another look here, only thing that should be done here is that width, height, x, y should be set to mainScreen.size.width, mainScreen.size.height, 0, 0 if fullscreen is true. Otherwise nothing should be done here.

[pciavald]

Why was the protocol removed? Was this tested on an actual machine or just in a dev environment?

The protocol was removed because it was not used when using full path for languages instead of the initial virtual path that can't be used with i18n. Tested in dev and prod for more than a month

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[pciavald]

I am sorry to announce that I do not have the work power to maintain all our changes in compliance with upstream requirements. This feature has been published to our repo CosmoDash.