-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor main.js, enable custom screensize #1627
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update install.sh Enable CORS by default * Update install.sh Moved CORS before OctoDash install. * Update install.sh Changed to if statement to verify if it is enabled first, if not, then enable it. * Update install.sh Changed to use installer script variables * Update install.sh Updated as requested. * Update install.sh Added red text color to CORS message. * Update scripts/install.sh Co-authored-by: Timon G. <[email protected]> * Update scripts/install.sh Co-authored-by: Timon G. <[email protected]> * Update install.sh Added color and attempted bold. It turns from red, to pink.. Co-authored-by: Timon G. <[email protected]>
* add typos, replace html logo by svg * fix css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off a merged #1610 as it was already modifying how the url is handled in main.js. Probably easier to look directly at main.js and helper/electron.js, this is where most of the change is.
I've extracted most of the electron-related logic into electron.js and grouped together behaviors that were a bit scattered in main.js. The logic is more state based and with the default values for BrowserWindow and state overrides, it was easy to implement custom window properties from the user config. As for the previous PR i've set everything to default to null so nothing gets overridden by default, but user can choose a different behavior.
As an example, we use it with these settings:
x is also exposed but we don't need it.
If you prefer that these are written by default in the config file, i can do it based on what's currently happening. Feel free to close if you don't want it in upstream.
The files diff will get much clearer when i18n is merged.
Fixes #1586