added thumbnail of file being printed to print progress view #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great Idea, although I don't like text in front of images. Give me some time to think about that (should also be configurable), I'll definitely come back to this PR :) |
|
Understood, that's why I had added the transparency so the text was more readable. |
|
I had some time and enabled OctoDash to show the preview while printing. See more information here: #570. Please let me know if you're fine with the other implementation, or what you want to be changed in the other PR. Adding this to the config so it defaults to showing the image might be added later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a simple change to show the thumbnail on the right side of the print progress status.