Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show preview while printing (click on percentage) #570

Merged
merged 2 commits into from
Apr 14, 2020

Conversation

UnchartedBull
Copy link
Owner

This while show the thumbnail of the current print if you click on the percentage. The choice should be remembered until a restart of OctoDash happens.

Demo:
Screen-Recording-2020-04-14-at-1

@jneilliii
Copy link
Contributor

That's totally cool and was what I tried implementing originally, but I couldn't figure out how to get beyond the control page on click.

@UnchartedBull
Copy link
Owner Author

That was a pain, did a little sneaky workaround which should work for now, but I may revisit that later.

@UnchartedBull UnchartedBull merged commit 924fa34 into master Apr 14, 2020
@UnchartedBull UnchartedBull deleted the feature/preview-while-printing branch April 14, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants