-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language Support for Statements and Answers #170
Open
dankim444
wants to merge
9
commits into
main
Choose a base branch
from
issue-146
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es when the language changes
Commonsense Run #98
Run Properties:
|
Project |
Commonsense
|
Branch Review |
issue-146
|
Run status |
Failed #98
|
Run duration | 01m 15s |
Commit |
31d65b2781: update locales for cypress tests
|
Committer | dankim444 |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
1
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
10
|
View all changes introduced in this branch ↗︎ |
Tests for review
cypress/e2e/1-functionality/formfill.cy.js • 1 failed test
Test | Artifacts | |
---|---|---|
fill out the survay > Select radio and click 'Next' in a loop |
Test Replay
Screenshots
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces multilingual support for both statements and answers in the UI and backend. On the frontend, we can now render survey statements and answers in the appropriate UI language. On the server side, the backend has been updated to track the UI language in submitted answers and retrieve the correct language-specific columns for both statements and answers. When merged, this PR will close #146.
Changes
Notes