-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify use of non-standard "align" attribute for mat-dialog-actions #18479
Comments
The dialog isn't meant to use the |
I would agree that this is confusing. Given that https://developer.mozilla.org/en-US/docs/Web/API/HTMLDivElement |
I could take this as my first issue I think. A fun christmas activity 😁🎅 |
Question: Would adding an input and removing the css code count as |
As of now, my solution would be a breaking for those using |
…tions directive instead of css Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479
…of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 for material-experimental
…of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 for material-experimental
…of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 for material-experimental
…of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 for material-experimental
…of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 for material-experimental
Squashed commit of the following: commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3 Merge: 3276432 3a98da8 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 31 19:24:24 2022 +0100 Merge branch 'master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 3276432 Merge: 815cf8f 1f40b7d Author: Jean-Philippe <[email protected]> Date: Mon Jan 31 18:54:42 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 815cf8f Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:23:12 2022 +0100 Use directive binding in mdc-dialog demo for align commit 77fca70 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:20:43 2022 +0100 Change actionsAlignment type in dialog demo commit c87c4aa Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 00:21:57 2022 +0100 Revert weird changes to dialog.spec.ts commit d6deb45 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:30:24 2022 +0100 Use 'start' as default instead of undefined for align attribute in dialog actions commit 8d367c1 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:05:54 2022 +0100 Update comments in dialog.scss for more clarity commit 9d2ac16 Merge: 54d0a60 3de4ab8 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 22:33:13 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479 commit 54d0a60 Merge: 462d407 c79e1d1 Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:30:29 2022 +0100 Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-angular#18479 commit c79e1d1 Merge: 462d407 03485cd Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:23:17 2022 +0100 Merge branch 'master' of https://github.com/angular/components into angular-master commit 462d407 Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:18:08 2020 +0100 fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 for material-experimental commit c101f7f Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:15:01 2020 +0100 fix(material/dialog): make align attribute into an input of dialog actions directive instead of css Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479
Squashed commit of the following: commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3 Merge: 3276432 3a98da8 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 31 19:24:24 2022 +0100 Merge branch 'master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 3276432 Merge: 815cf8f 1f40b7d Author: Jean-Philippe <[email protected]> Date: Mon Jan 31 18:54:42 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 815cf8f Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:23:12 2022 +0100 Use directive binding in mdc-dialog demo for align commit 77fca70 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:20:43 2022 +0100 Change actionsAlignment type in dialog demo commit c87c4aa Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 00:21:57 2022 +0100 Revert weird changes to dialog.spec.ts commit d6deb45 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:30:24 2022 +0100 Use 'start' as default instead of undefined for align attribute in dialog actions commit 8d367c1 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:05:54 2022 +0100 Update comments in dialog.scss for more clarity commit 9d2ac16 Merge: 54d0a60 3de4ab8 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 22:33:13 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479 commit 54d0a60 Merge: 462d407 c79e1d1 Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:30:29 2022 +0100 Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-angular#18479 commit c79e1d1 Merge: 462d407 03485cd Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:23:17 2022 +0100 Merge branch 'master' of https://github.com/angular/components into angular-master commit 462d407 Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:18:08 2020 +0100 fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 for material-experimental commit c101f7f Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:15:01 2020 +0100 fix(material/dialog): make align attribute into an input of dialog actions directive instead of css Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479
commit 261cb7c Author: Jean-Philippe Green <[email protected]> Date: Tue Feb 1 21:26:03 2022 +0100 fix(material/dialog): Fix mdc action align test commit b060272 Author: Jean-Philippe Green <[email protected]> Date: Tue Feb 1 21:10:12 2022 +0100 fix(material/dialog): update golden api for dialog commit 69491e1 Author: Jean-Philippe Green <[email protected]> Date: Tue Feb 1 17:50:37 2022 +0100 fix(material/dialog): fix mismatching test names between mdc and non-mdc commit b4a9cb3 Author: Paul Gschwendtner <[email protected]> Date: Tue Feb 1 17:09:37 2022 +0100 fixup! fix(material/dialog): Use align as @input() in MatDialogActions ds commit d7a9cbb Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 31 19:27:13 2022 +0100 fix(material/dialog): Use align as @input() in MatDialogActions Squashed commit of the following: commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3 Merge: 3276432 3a98da8 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 31 19:24:24 2022 +0100 Merge branch 'master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 3276432 Merge: 815cf8f 1f40b7d Author: Jean-Philippe <[email protected]> Date: Mon Jan 31 18:54:42 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 815cf8f Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:23:12 2022 +0100 Use directive binding in mdc-dialog demo for align commit 77fca70 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:20:43 2022 +0100 Change actionsAlignment type in dialog demo commit c87c4aa Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 00:21:57 2022 +0100 Revert weird changes to dialog.spec.ts commit d6deb45 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:30:24 2022 +0100 Use 'start' as default instead of undefined for align attribute in dialog actions commit 8d367c1 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:05:54 2022 +0100 Update comments in dialog.scss for more clarity commit 9d2ac16 Merge: 54d0a60 3de4ab8 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 22:33:13 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479 commit 54d0a60 Merge: 462d407 c79e1d1 Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:30:29 2022 +0100 Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-angular#18479 commit c79e1d1 Merge: 462d407 03485cd Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:23:17 2022 +0100 Merge branch 'master' of https://github.com/angular/components into angular-master commit 462d407 Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:18:08 2020 +0100 fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 for material-experimental commit c101f7f Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:15:01 2020 +0100 fix(material/dialog): make align attribute into an input of dialog actions directive instead of css Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 commit a74d92e Author: Kristiyan Kostadinov <[email protected]> Date: Tue Feb 1 16:43:35 2022 +0100 fix(material/menu): adjust overlay size when amount of items changes (angular#21457) Currently we lock the menu into a position after it is opened so that it doesn't jump around when the user scrolls, but this means that if the amount of items changes, it might not be the optimal position anymore. These changes add some code to re-calculate the position if the amount of items changes. Fixes angular#21456. commit f201634 Author: Kristiyan Kostadinov <[email protected]> Date: Tue Feb 1 13:22:16 2022 +0100 build: fix rules_sass error (angular#24331) Updates to the latest version of `rules_sass` in order to fix an error that is currently breaking the build.
Merge remote-tracking branch 'origin/master' into align-attr-as-input-in-dialog-actions-angular#18479-3
…-poo' into align-attr-as-input-in-dialog-actions-angular#18479-3
…#24328) * fix(material/dialog): Use align as @input() in MatDialogActions Squashed commit of the following: commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3 Merge: 3276432 3a98da8 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 31 19:24:24 2022 +0100 Merge branch 'master' into align-attr-as-input-in-dialog-actions-#18479-2 commit 3276432 Merge: 815cf8f 1f40b7d Author: Jean-Philippe <[email protected]> Date: Mon Jan 31 18:54:42 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-#18479-2 commit 815cf8f Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:23:12 2022 +0100 Use directive binding in mdc-dialog demo for align commit 77fca70 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:20:43 2022 +0100 Change actionsAlignment type in dialog demo commit c87c4aa Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 00:21:57 2022 +0100 Revert weird changes to dialog.spec.ts commit d6deb45 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:30:24 2022 +0100 Use 'start' as default instead of undefined for align attribute in dialog actions commit 8d367c1 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:05:54 2022 +0100 Update comments in dialog.scss for more clarity commit 9d2ac16 Merge: 54d0a60 3de4ab8 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 22:33:13 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-#18479 commit 54d0a60 Merge: 462d407 c79e1d1 Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:30:29 2022 +0100 Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-#18479 commit c79e1d1 Merge: 462d407 03485cd Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:23:17 2022 +0100 Merge branch 'master' of https://github.com/angular/components into angular-master commit 462d407 Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:18:08 2020 +0100 fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes #18479 for material-experimental commit c101f7f Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:15:01 2020 +0100 fix(material/dialog): make align attribute into an input of dialog actions directive instead of css Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes #18479 * fix(material/dialog): Use align as @input() in MatDialogActions Squashed commit of the following: commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3 Merge: 3276432 3a98da8 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 31 19:24:24 2022 +0100 Merge branch 'master' into align-attr-as-input-in-dialog-actions-#18479-2 commit 3276432 Merge: 815cf8f 1f40b7d Author: Jean-Philippe <[email protected]> Date: Mon Jan 31 18:54:42 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-#18479-2 commit 815cf8f Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:23:12 2022 +0100 Use directive binding in mdc-dialog demo for align commit 77fca70 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:20:43 2022 +0100 Change actionsAlignment type in dialog demo commit c87c4aa Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 00:21:57 2022 +0100 Revert weird changes to dialog.spec.ts commit d6deb45 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:30:24 2022 +0100 Use 'start' as default instead of undefined for align attribute in dialog actions commit 8d367c1 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:05:54 2022 +0100 Update comments in dialog.scss for more clarity commit 9d2ac16 Merge: 54d0a60 3de4ab8 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 22:33:13 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-#18479 commit 54d0a60 Merge: 462d407 c79e1d1 Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:30:29 2022 +0100 Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-#18479 commit c79e1d1 Merge: 462d407 03485cd Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:23:17 2022 +0100 Merge branch 'master' of https://github.com/angular/components into angular-master commit 462d407 Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:18:08 2020 +0100 fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes #18479 for material-experimental commit c101f7f Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:15:01 2020 +0100 fix(material/dialog): make align attribute into an input of dialog actions directive instead of css Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes #18479 * fixup! fix(material/dialog): Use align as @input() in MatDialogActions ds * fix(material/dialog): fix mismatching test names between mdc and non-mdc * fix(material/dialog): fix mismatching test names between mdc and non-mdc * fix(material/dialog): update golden api for dialog * fix(material/dialog): Fix mdc action align test * fix(material/dialog): update golden api for dialog * fix(material/dialog): Fix mdc action align test * fix(material/dialog): Squashed commit of the following: commit 261cb7c Author: Jean-Philippe Green <[email protected]> Date: Tue Feb 1 21:26:03 2022 +0100 fix(material/dialog): Fix mdc action align test commit b060272 Author: Jean-Philippe Green <[email protected]> Date: Tue Feb 1 21:10:12 2022 +0100 fix(material/dialog): update golden api for dialog commit 69491e1 Author: Jean-Philippe Green <[email protected]> Date: Tue Feb 1 17:50:37 2022 +0100 fix(material/dialog): fix mismatching test names between mdc and non-mdc commit b4a9cb3 Author: Paul Gschwendtner <[email protected]> Date: Tue Feb 1 17:09:37 2022 +0100 fixup! fix(material/dialog): Use align as @input() in MatDialogActions ds commit d7a9cbb Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 31 19:27:13 2022 +0100 fix(material/dialog): Use align as @input() in MatDialogActions Squashed commit of the following: commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3 Merge: 3276432 3a98da8 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 31 19:24:24 2022 +0100 Merge branch 'master' into align-attr-as-input-in-dialog-actions-#18479-2 commit 3276432 Merge: 815cf8f 1f40b7d Author: Jean-Philippe <[email protected]> Date: Mon Jan 31 18:54:42 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-#18479-2 commit 815cf8f Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:23:12 2022 +0100 Use directive binding in mdc-dialog demo for align commit 77fca70 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:20:43 2022 +0100 Change actionsAlignment type in dialog demo commit c87c4aa Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 00:21:57 2022 +0100 Revert weird changes to dialog.spec.ts commit d6deb45 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:30:24 2022 +0100 Use 'start' as default instead of undefined for align attribute in dialog actions commit 8d367c1 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:05:54 2022 +0100 Update comments in dialog.scss for more clarity commit 9d2ac16 Merge: 54d0a60 3de4ab8 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 22:33:13 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-#18479 commit 54d0a60 Merge: 462d407 c79e1d1 Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:30:29 2022 +0100 Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-#18479 commit c79e1d1 Merge: 462d407 03485cd Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:23:17 2022 +0100 Merge branch 'master' of https://github.com/angular/components into angular-master commit 462d407 Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:18:08 2020 +0100 fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes #18479 for material-experimental commit c101f7f Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:15:01 2020 +0100 fix(material/dialog): make align attribute into an input of dialog actions directive instead of css Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes #18479 commit a74d92e Author: Kristiyan Kostadinov <[email protected]> Date: Tue Feb 1 16:43:35 2022 +0100 fix(material/menu): adjust overlay size when amount of items changes (#21457) Currently we lock the menu into a position after it is opened so that it doesn't jump around when the user scrolls, but this means that if the amount of items changes, it might not be the optimal position anymore. These changes add some code to re-calculate the position if the amount of items changes. Fixes #21456. commit f201634 Author: Kristiyan Kostadinov <[email protected]> Date: Tue Feb 1 13:22:16 2022 +0100 build: fix rules_sass error (#24331) Updates to the latest version of `rules_sass` in order to fix an error that is currently breaking the build. Co-authored-by: Paul Gschwendtner <[email protected]>
…angular#24328) * fix(material/dialog): Use align as @input() in MatDialogActions Squashed commit of the following: commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3 Merge: 3276432 3a98da8 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 31 19:24:24 2022 +0100 Merge branch 'master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 3276432 Merge: 815cf8f 1f40b7d Author: Jean-Philippe <[email protected]> Date: Mon Jan 31 18:54:42 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 815cf8f Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:23:12 2022 +0100 Use directive binding in mdc-dialog demo for align commit 77fca70 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:20:43 2022 +0100 Change actionsAlignment type in dialog demo commit c87c4aa Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 00:21:57 2022 +0100 Revert weird changes to dialog.spec.ts commit d6deb45 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:30:24 2022 +0100 Use 'start' as default instead of undefined for align attribute in dialog actions commit 8d367c1 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:05:54 2022 +0100 Update comments in dialog.scss for more clarity commit 9d2ac16 Merge: 54d0a60 3de4ab8 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 22:33:13 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479 commit 54d0a60 Merge: 462d407 c79e1d1 Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:30:29 2022 +0100 Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-angular#18479 commit c79e1d1 Merge: 462d407 03485cd Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:23:17 2022 +0100 Merge branch 'master' of https://github.com/angular/components into angular-master commit 462d407 Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:18:08 2020 +0100 fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 for material-experimental commit c101f7f Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:15:01 2020 +0100 fix(material/dialog): make align attribute into an input of dialog actions directive instead of css Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 * fix(material/dialog): Use align as @input() in MatDialogActions Squashed commit of the following: commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3 Merge: 3276432 3a98da8 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 31 19:24:24 2022 +0100 Merge branch 'master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 3276432 Merge: 815cf8f 1f40b7d Author: Jean-Philippe <[email protected]> Date: Mon Jan 31 18:54:42 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 815cf8f Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:23:12 2022 +0100 Use directive binding in mdc-dialog demo for align commit 77fca70 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:20:43 2022 +0100 Change actionsAlignment type in dialog demo commit c87c4aa Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 00:21:57 2022 +0100 Revert weird changes to dialog.spec.ts commit d6deb45 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:30:24 2022 +0100 Use 'start' as default instead of undefined for align attribute in dialog actions commit 8d367c1 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:05:54 2022 +0100 Update comments in dialog.scss for more clarity commit 9d2ac16 Merge: 54d0a60 3de4ab8 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 22:33:13 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479 commit 54d0a60 Merge: 462d407 c79e1d1 Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:30:29 2022 +0100 Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-angular#18479 commit c79e1d1 Merge: 462d407 03485cd Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:23:17 2022 +0100 Merge branch 'master' of https://github.com/angular/components into angular-master commit 462d407 Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:18:08 2020 +0100 fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 for material-experimental commit c101f7f Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:15:01 2020 +0100 fix(material/dialog): make align attribute into an input of dialog actions directive instead of css Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 * fixup! fix(material/dialog): Use align as @input() in MatDialogActions ds * fix(material/dialog): fix mismatching test names between mdc and non-mdc * fix(material/dialog): fix mismatching test names between mdc and non-mdc * fix(material/dialog): update golden api for dialog * fix(material/dialog): Fix mdc action align test * fix(material/dialog): update golden api for dialog * fix(material/dialog): Fix mdc action align test * fix(material/dialog): Squashed commit of the following: commit 261cb7c Author: Jean-Philippe Green <[email protected]> Date: Tue Feb 1 21:26:03 2022 +0100 fix(material/dialog): Fix mdc action align test commit b060272 Author: Jean-Philippe Green <[email protected]> Date: Tue Feb 1 21:10:12 2022 +0100 fix(material/dialog): update golden api for dialog commit 69491e1 Author: Jean-Philippe Green <[email protected]> Date: Tue Feb 1 17:50:37 2022 +0100 fix(material/dialog): fix mismatching test names between mdc and non-mdc commit b4a9cb3 Author: Paul Gschwendtner <[email protected]> Date: Tue Feb 1 17:09:37 2022 +0100 fixup! fix(material/dialog): Use align as @input() in MatDialogActions ds commit d7a9cbb Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 31 19:27:13 2022 +0100 fix(material/dialog): Use align as @input() in MatDialogActions Squashed commit of the following: commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3 Merge: 3276432 3a98da8 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 31 19:24:24 2022 +0100 Merge branch 'master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 3276432 Merge: 815cf8f 1f40b7d Author: Jean-Philippe <[email protected]> Date: Mon Jan 31 18:54:42 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 815cf8f Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:23:12 2022 +0100 Use directive binding in mdc-dialog demo for align commit 77fca70 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:20:43 2022 +0100 Change actionsAlignment type in dialog demo commit c87c4aa Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 00:21:57 2022 +0100 Revert weird changes to dialog.spec.ts commit d6deb45 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:30:24 2022 +0100 Use 'start' as default instead of undefined for align attribute in dialog actions commit 8d367c1 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:05:54 2022 +0100 Update comments in dialog.scss for more clarity commit 9d2ac16 Merge: 54d0a60 3de4ab8 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 22:33:13 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479 commit 54d0a60 Merge: 462d407 c79e1d1 Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:30:29 2022 +0100 Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-angular#18479 commit c79e1d1 Merge: 462d407 03485cd Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:23:17 2022 +0100 Merge branch 'master' of https://github.com/angular/components into angular-master commit 462d407 Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:18:08 2020 +0100 fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 for material-experimental commit c101f7f Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:15:01 2020 +0100 fix(material/dialog): make align attribute into an input of dialog actions directive instead of css Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 commit a74d92e Author: Kristiyan Kostadinov <[email protected]> Date: Tue Feb 1 16:43:35 2022 +0100 fix(material/menu): adjust overlay size when amount of items changes (angular#21457) Currently we lock the menu into a position after it is opened so that it doesn't jump around when the user scrolls, but this means that if the amount of items changes, it might not be the optimal position anymore. These changes add some code to re-calculate the position if the amount of items changes. Fixes angular#21456. commit f201634 Author: Kristiyan Kostadinov <[email protected]> Date: Tue Feb 1 13:22:16 2022 +0100 build: fix rules_sass error (angular#24331) Updates to the latest version of `rules_sass` in order to fix an error that is currently breaking the build. Co-authored-by: Paul Gschwendtner <[email protected]>
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…angular#24328) * fix(material/dialog): Use align as @input() in MatDialogActions Squashed commit of the following: commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3 Merge: 3276432 3a98da8 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 31 19:24:24 2022 +0100 Merge branch 'master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 3276432 Merge: 815cf8f 1f40b7d Author: Jean-Philippe <[email protected]> Date: Mon Jan 31 18:54:42 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 815cf8f Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:23:12 2022 +0100 Use directive binding in mdc-dialog demo for align commit 77fca70 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:20:43 2022 +0100 Change actionsAlignment type in dialog demo commit c87c4aa Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 00:21:57 2022 +0100 Revert weird changes to dialog.spec.ts commit d6deb45 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:30:24 2022 +0100 Use 'start' as default instead of undefined for align attribute in dialog actions commit 8d367c1 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:05:54 2022 +0100 Update comments in dialog.scss for more clarity commit 9d2ac16 Merge: 54d0a60 3de4ab8 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 22:33:13 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479 commit 54d0a60 Merge: 462d407 c79e1d1 Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:30:29 2022 +0100 Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-angular#18479 commit c79e1d1 Merge: 462d407 03485cd Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:23:17 2022 +0100 Merge branch 'master' of https://github.com/angular/components into angular-master commit 462d407 Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:18:08 2020 +0100 fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 for material-experimental commit c101f7f Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:15:01 2020 +0100 fix(material/dialog): make align attribute into an input of dialog actions directive instead of css Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 * fix(material/dialog): Use align as @input() in MatDialogActions Squashed commit of the following: commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3 Merge: 3276432 3a98da8 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 31 19:24:24 2022 +0100 Merge branch 'master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 3276432 Merge: 815cf8f 1f40b7d Author: Jean-Philippe <[email protected]> Date: Mon Jan 31 18:54:42 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 815cf8f Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:23:12 2022 +0100 Use directive binding in mdc-dialog demo for align commit 77fca70 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:20:43 2022 +0100 Change actionsAlignment type in dialog demo commit c87c4aa Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 00:21:57 2022 +0100 Revert weird changes to dialog.spec.ts commit d6deb45 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:30:24 2022 +0100 Use 'start' as default instead of undefined for align attribute in dialog actions commit 8d367c1 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:05:54 2022 +0100 Update comments in dialog.scss for more clarity commit 9d2ac16 Merge: 54d0a60 3de4ab8 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 22:33:13 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479 commit 54d0a60 Merge: 462d407 c79e1d1 Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:30:29 2022 +0100 Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-angular#18479 commit c79e1d1 Merge: 462d407 03485cd Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:23:17 2022 +0100 Merge branch 'master' of https://github.com/angular/components into angular-master commit 462d407 Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:18:08 2020 +0100 fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 for material-experimental commit c101f7f Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:15:01 2020 +0100 fix(material/dialog): make align attribute into an input of dialog actions directive instead of css Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 * fixup! fix(material/dialog): Use align as @input() in MatDialogActions ds * fix(material/dialog): fix mismatching test names between mdc and non-mdc * fix(material/dialog): fix mismatching test names between mdc and non-mdc * fix(material/dialog): update golden api for dialog * fix(material/dialog): Fix mdc action align test * fix(material/dialog): update golden api for dialog * fix(material/dialog): Fix mdc action align test * fix(material/dialog): Squashed commit of the following: commit 261cb7c Author: Jean-Philippe Green <[email protected]> Date: Tue Feb 1 21:26:03 2022 +0100 fix(material/dialog): Fix mdc action align test commit b060272 Author: Jean-Philippe Green <[email protected]> Date: Tue Feb 1 21:10:12 2022 +0100 fix(material/dialog): update golden api for dialog commit 69491e1 Author: Jean-Philippe Green <[email protected]> Date: Tue Feb 1 17:50:37 2022 +0100 fix(material/dialog): fix mismatching test names between mdc and non-mdc commit b4a9cb3 Author: Paul Gschwendtner <[email protected]> Date: Tue Feb 1 17:09:37 2022 +0100 fixup! fix(material/dialog): Use align as @input() in MatDialogActions ds commit d7a9cbb Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 31 19:27:13 2022 +0100 fix(material/dialog): Use align as @input() in MatDialogActions Squashed commit of the following: commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3 Merge: 3276432 3a98da8 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 31 19:24:24 2022 +0100 Merge branch 'master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 3276432 Merge: 815cf8f 1f40b7d Author: Jean-Philippe <[email protected]> Date: Mon Jan 31 18:54:42 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 815cf8f Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:23:12 2022 +0100 Use directive binding in mdc-dialog demo for align commit 77fca70 Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 01:20:43 2022 +0100 Change actionsAlignment type in dialog demo commit c87c4aa Author: Jean-Philippe Green <[email protected]> Date: Mon Jan 10 00:21:57 2022 +0100 Revert weird changes to dialog.spec.ts commit d6deb45 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:30:24 2022 +0100 Use 'start' as default instead of undefined for align attribute in dialog actions commit 8d367c1 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 23:05:54 2022 +0100 Update comments in dialog.scss for more clarity commit 9d2ac16 Merge: 54d0a60 3de4ab8 Author: Jean-Philippe <[email protected]> Date: Sun Jan 9 22:33:13 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479 commit 54d0a60 Merge: 462d407 c79e1d1 Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:30:29 2022 +0100 Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-angular#18479 commit c79e1d1 Merge: 462d407 03485cd Author: Jean-Philippe Green <[email protected]> Date: Wed Jan 5 21:23:17 2022 +0100 Merge branch 'master' of https://github.com/angular/components into angular-master commit 462d407 Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:18:08 2020 +0100 fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 for material-experimental commit c101f7f Author: Jean-Philippe Green <[email protected]> Date: Fri Dec 25 16:15:01 2020 +0100 fix(material/dialog): make align attribute into an input of dialog actions directive instead of css Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 commit a74d92e Author: Kristiyan Kostadinov <[email protected]> Date: Tue Feb 1 16:43:35 2022 +0100 fix(material/menu): adjust overlay size when amount of items changes (angular#21457) Currently we lock the menu into a position after it is opened so that it doesn't jump around when the user scrolls, but this means that if the amount of items changes, it might not be the optimal position anymore. These changes add some code to re-calculate the position if the amount of items changes. Fixes angular#21456. commit f201634 Author: Kristiyan Kostadinov <[email protected]> Date: Tue Feb 1 13:22:16 2022 +0100 build: fix rules_sass error (angular#24331) Updates to the latest version of `rules_sass` in order to fix an error that is currently breaking the build. Co-authored-by: Paul Gschwendtner <[email protected]>
Documentation Feedback
Documentation suggests using the
align
attribute to align the content ofmat-dialog-actions
directives to the middle or right. However,align
is an obsolete HTML attribute and not valid HTML5, and my IDE's static code analysis tools rightfully complain about using it. If usingalign
really is the right way of doing this regardless of W3C standards, this should be clarified in the docs (and possibly be explicitly declared as a property of theMatDialogActions
directive to make IDEs stop complaining).Affected documentation page: https://material.angular.io/components/dialog/overview
The text was updated successfully, but these errors were encountered: