Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop old version of Visual Studio C++ (2013, 2015, 2017) #3723

Closed
KvanTTT opened this issue May 26, 2022 · 1 comment
Closed

Drop old version of Visual Studio C++ (2013, 2015, 2017) #3723

KvanTTT opened this issue May 26, 2022 · 1 comment
Labels
comp:build target:cpp
Milestone
4.11

Comments

@KvanTTT
Copy link
Member

KvanTTT commented May 26, 2022 •
edited
Loading

Currently we have the following .vsxproj files:

  • antlr4cpp-vs2013.vcxproj
  • antlr4cpp-vs2015.vcxproj
  • antlr4cpp-vs2017.vcxproj
  • antlr4cpp-vs2019.vcxproj

I suggest removing the first three and adding antlr4cpp-vs2022.vcxproj:

  • antlr4cpp-vs2019.vcxproj
  • antlr4cpp-vs2022.vcxproj

@mike-lischke what do you think?

Also, these projects can't be built because they weren't updated after some files removing (for instance, ATNSerializer.cpp).
@KvanTTT KvanTTT changed the title Drop old version of Visual Studio (2013, 2015, 2017) Drop old version of Visual Studio C++ (2013, 2015, 2017) May 26, 2022
@mike-lischke
Copy link
Member

Makes sense, yes. Actually, I expect that PRs which change the file structure also update all project files (cmake, xcode, vcxproj), but I have to admit, I didn't check that in all PRs I approved. Unfortunately, those people who know cmake are usually not familiar with IDE project files and vice versa.

KvanTTT added a commit to KvanTTT/antlr4 that referenced this issue May 27, 2022
@KvanTTT
Set up runtime tests on Windows using msbuild, fixes antlr#3389
9238268 
Drop old version of Visual Studio C++ (2013, 2015, 2017), fixes antlr#3723

Signed-off-by: Ivan Kochurkin <[email protected]>
KvanTTT added a commit to KvanTTT/antlr4 that referenced this issue May 27, 2022
@KvanTTT
Set up runtime tests on Windows using msbuild, fixes antlr#3389
86fae81 
Drop old version of Visual Studio C++ (2013, 2015, 2017), fixes antlr#3723

Signed-off-by: Ivan Kochurkin <[email protected]>
KvanTTT added a commit to KvanTTT/antlr4 that referenced this issue May 27, 2022
@KvanTTT
Set up runtime tests on Windows using msbuild, fixes antlr#3389
4c18f46 
Drop old version of Visual Studio C++ (2013, 2015, 2017), fixes antlr#3723

Signed-off-by: Ivan Kochurkin <[email protected]>
KvanTTT added a commit to KvanTTT/antlr4 that referenced this issue Jun 5, 2022
@KvanTTT
Set up C++ runtime tests on Windows using msbuild, fixes antlr#3389
e7355f3 
Drop old version of Visual Studio C++ (2013, 2015, 2017), fixes antlr#3723

Signed-off-by: Ivan Kochurkin <[email protected]>
parrt pushed a commit that referenced this issue Jun 5, 2022
@KvanTTT @parrt
Set up C++ runtime tests on Windows using msbuild, fixes #3389
d761b55 
Drop old version of Visual Studio C++ (2013, 2015, 2017), fixes #3723

Signed-off-by: Ivan Kochurkin <[email protected]>
@KvanTTT KvanTTT closed this as completed Jun 6, 2022
@KvanTTT KvanTTT mentioned this issue Jun 6, 2022
Merged
@parrt parrt added this to the 4.10.2 milestone Jun 6, 2022
@admin-token-bot admin-token-bot mentioned this issue Jul 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:build target:cpp
Projects
None yet
Milestone
4.11
Development

No branches or pull requests
3 participants
@parrt @KvanTTT @mike-lischke