[C++] do not hardcode Unix Makefiles generator #2745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the lack of Jira issue. I'm not sure how to create one. Also I tested this at least locally, and all the affected targets work fine for me. Please tell me if this breaks anything for you (it shouldn't though) |
martin-g
requested changes
Feb 19, 2024
| @@ -71,7 +71,6 @@ function do_dist() { | |||
| fi | |||
| } | |||
|
|
|||
| (mkdir -p build; cd build; cmake --version; cmake -G "Unix Makefiles" ..) | |||
There was a problem hiding this comment.
The clean target fails if another target that creates the build/ folder is not executed first.
avro/lang/c++ on mkmkme/no-make [$?] via △ v3.22.1
❯ ./build.sh clean
Error: /home/martin/git/apache/avro/lang/c++/build is not a directory
There was a problem hiding this comment.
Ah true! Thanks, I'll fix it.
There was a problem hiding this comment.
Added a configuration step before the loop
Instead, use `cmake --build`. It has been mentioned at least in cmake 3.2 documentation [1] which has been released in 2015. This will make a build process more flexible to people who want to use different build systems such as Ninja. [1]: https://cmake.org/cmake/help/v3.2/manual/cmake.1.html
mkmkme
force-pushed
the
mkmkme/no-make
branch
from
0eae62c
to
6f977a7
Compare
martin-g
pushed a commit
that referenced
this pull request
Feb 19, 2024
Instead, use `cmake --build`. It has been mentioned at least in cmake 3.2 documentation [1] which has been released in 2015. This will make a build process more flexible to people who want to use different build systems such as Ninja. [1]: https://cmake.org/cmake/help/v3.2/manual/cmake.1.html (cherry picked from commit c66e8ca)
|
Thank you, @mkmkme ! |
RanbirK
pushed a commit
to RanbirK/avro
that referenced
this pull request
May 13, 2024
Instead, use `cmake --build`. It has been mentioned at least in cmake 3.2 documentation [1] which has been released in 2015. This will make a build process more flexible to people who want to use different build systems such as Ninja. [1]: https://cmake.org/cmake/help/v3.2/manual/cmake.1.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, use
cmake --build. It has been mentioned at least in cmake 3.2 documentation 1 which has been released in 2015. This will make a build process more flexible to people who want to use different build systems such as Ninja.What is the purpose of the change
This change makes the build process slightly more flexible to people who use different build systems.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation