AVRO-1830 [Perl] Support containers without codec #2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjatria
force-pushed
the
avro-1830-default-codec
branch
from
cb33fda
to
df144a9
Compare
martin-g
approved these changes
Jun 24, 2024
|
There are conflicts in the CHANGES file but I cannot resolve them because we (the maintainers) do not have permissions to push to your branch. |
As [the specification on Object Container Files][spec] states (emphasis added): > All metadata properties that start with "avro." are reserved. > The following file metadata properties are currently used: > > * **avro.schema** contains the schema of objects stored in > the file, as JSON data (required). > * **avro.codec** the name of the compression codec used to > compress blocks, as a string. Implementations are required > to support the following codecs: "null" and "deflate". _If > codec is absent, it is assumed to be "null"_. The codecs are > described with more detail below. This change makes it so that the Perl implementation does not die when opening a container that does not contain an explicit codec in its metadata. This change is inspired by one originally submitted in 2016 by SK Liew. [spec]: https://avro.apache.org/docs/1.11.1/specification/#object-container-files
jjatria
force-pushed
the
avro-1830-default-codec
branch
from
df144a9
to
eead0e4
Compare
|
@martin-g: I've rebased this on main and force pushed without the conflict 👍 |
martin-g
approved these changes
Jun 24, 2024
|
Thank you, @jjatria ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the specification on Object Container Files states (emphasis added):
This change makes it so that the Perl implementation does not die when opening a container that does not contain an explicit codec in its metadata.
This change is inspired by one originally submitted in 2016 by SK Liew and tracked in https://issues.apache.org/jira/browse/AVRO-1830.
Verifying this change
This change added a new test case to
t/04_datafile.tand will be verified as part of the normal test suite. The test attempts to read data from a manually crafted container that explicitly does not contain a codec. The file was manually confirmed to be readable by utilities likeavrocat, which shows it to be a valid file outside the specific test case.Documentation
Unfortunately, the Perl library is severely underdocumented, so there is nothing to add this to.