Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVRO-1830 [Perl] Support containers without codec #2965

Merged
merged 1 commit into from
Jun 24, 2024
Merged

AVRO-1830 [Perl] Support containers without codec #2965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lang/perl/Changes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ Revision history for Perl extension Avro
multiple JSON backends
- Drop dependency on IO::String, since we don't need
it now we depend on Perl 5.10.1 or greater
- Support object containers without an explicit
codec. It will be assumed to be 'null' as mandated
by the spec.

1.00 Fri Jan 17 15:00:00 2014
- Relicense under apache license 2.0
Expand Down
4 changes: 2 additions & 2 deletions lang/perl/lib/Avro/DataFileReader.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ sub new {

sub codec {
my $datafile = shift;
return $datafile->metadata->{'avro.codec'};
return $datafile->metadata->{'avro.codec'} || 'null';
}

sub writer_schema {
Expand Down Expand Up @@ -99,7 +99,7 @@ sub read_file_header {
$datafile->{sync_marker} = $data->{sync}
or croak "sync marker appears invalid";

my $codec = $data->{meta}{'avro.codec'} || "";
my $codec = $data->{meta}{'avro.codec'} || 'null';

throw Avro::DataFile::Error::UnsupportedCodec($codec)
unless Avro::DataFile->is_codec_valid($codec);
Expand Down
17 changes: 17 additions & 0 deletions lang/perl/t/04_datafile.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,4 +221,21 @@ is_deeply $all[0], $data, "Our data is intact!";
is scalar @next, 0, "no more objects back";
}

## Test with a datafile that has no codec
{
my $container = join '',
"Obj\x{01}",
"\x{02}\x{16}avro.schema\x{10}\x{22}string\x{22}\x{00}",
"\x{de}\x{ad}\x{be}\x{ef}" x 4,
"\x{02}\x{08}\x{06}foo",
"\x{de}\x{ad}\x{be}\x{ef}" x 4;

open my $fh, '<', \$container or die "Could not open memory handle: $!";

my $reader = Avro::DataFileReader->new( fh => $fh );

my ($data) = $reader->next(1);
is $data, 'foo', 'Can read data from container without a codec';
}

done_testing;