Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to VS2019 for passing the cpp build #567

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

aaron-ai
Copy link
Member

@aaron-ai aaron-ai commented Jul 12, 2023

Which Issue(s) This PR Fixes

Fixes #569

Brief Description

This change only affects the Bazel build in the CI and makes the CI green again. Because of an update of Visual Studio the Bazel Windows Build is failing - more details here: bazelbuild/bazel#18592

One workaround is to use VS 2019 for now, until this is fixed. Another option would be to modify the directory of VS2022. Once this is fixed the Bazel Windows CI build will switch back to VS2022.

How Did You Test This Change?

@aaron-ai aaron-ai changed the title Test for cpp build Switch back to VS2019 for cpp's build Jul 13, 2023
@aaron-ai aaron-ai changed the title Switch back to VS2019 for cpp's build Switch back to VS2019 for passing the cpp build Jul 13, 2023
Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit cb7d16d into apache:master Jul 13, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Bazel toolchain is not compatible with windows2022
2 participants