Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconstruction for Hint Manager. #1303

Merged
merged 33 commits into from
Sep 26, 2018
Merged

Reconstruction for Hint Manager. #1303

merged 33 commits into from
Sep 26, 2018

Conversation

tristaZero
Copy link
Contributor

Fixes #1289.

Changes proposed in this pull request:

  • Reconstruct Hint manager.
  • Reconstruct Hint manager holder.
  • Modify some cases.

@coveralls
Copy link

coveralls commented Sep 26, 2018

Pull Request Test Coverage Report for Build 5246

  • 31 of 32 (96.88%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 62.859%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sharding-core/src/main/java/io/shardingsphere/core/hint/HintManagerHolder.java 27 28 96.43%
Files with Coverage Reduction New Missed Lines %
sharding-core/src/main/java/io/shardingsphere/core/hint/HintManagerHolder.java 1 94.29%
sharding-orchestration/sharding-orchestration-reg/src/main/java/io/shardingsphere/orchestration/reg/newzk/client/zookeeper/base/Holder.java 3 70.49%
Totals Coverage Status
Change from base Build 5243: -0.02%
Covered Lines: 8061
Relevant Lines: 12824

💛 - Coveralls

@terrymanu terrymanu merged commit 8dab10e into apache:dev Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants