-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: remove ENABLE_REACT_CRUD_VIEWS
feature flag (permanently enable)
#19231
Conversation
if (this.state.hash && this.state.hash === '#search') { | ||
if (isFeatureEnabled(FeatureFlag.ENABLE_REACT_CRUD_VIEWS)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept this logic consistent with permanently enabling the flag, but the logic doesn't look quite right to me. Shouldn't we be rendering with react instead of location.replace
ing when react crud is enabled?
Codecov Report
@@ Coverage Diff @@
## master #19231 +/- ##
==========================================
- Coverage 66.77% 66.53% -0.24%
==========================================
Files 1670 1670
Lines 64385 64376 -9
Branches 6501 6498 -3
==========================================
- Hits 42994 42835 -159
- Misses 19707 19858 +151
+ Partials 1684 1683 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -429,6 +429,7 @@ def test_slices(self): | |||
self.assertEqual(resp.status_code, 200) | |||
|
|||
def test_tablemodelview_list(self): | |||
pytest.skip("Depends on ENABLE_REACT_CRUD_VIEWS=False") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm skipping these and requesting Preset QA to help with replacing the lost test coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there's any real loss of coverage here. ENABLE_REACT_CRUD_VIEWS=True
has been the case for most large deployment of superset so far, so these test are just covering functionality that no one is using. The api tests and js tests provide decent coverage for the new crud view, imo.
SUMMARY
for 2.0
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
ENABLE_REACT_CRUD_VIEWS
flag, and sweep up old code #18908