Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: remove ENABLE_REACT_CRUD_VIEWS feature flag (permanently enable) #19231

Merged
merged 9 commits into from
Mar 18, 2022
Merged

chore!: remove ENABLE_REACT_CRUD_VIEWS feature flag (permanently enable) #19231

merged 9 commits into from
Mar 18, 2022

Conversation

suddjian
Copy link
Member

@suddjian suddjian commented Mar 17, 2022 •
edited
Loading

SUMMARY

for 2.0

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: closes [2.0] Remove ENABLE_REACT_CRUD_VIEWS flag, and sweep up old code #18908
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

suddjian
suddjian commented Mar 17, 2022
View reviewed changes
superset-frontend/src/SqlLab/components/App/index.jsx
if (this.state.hash && this.state.hash === '#search') {
if (isFeatureEnabled(FeatureFlag.ENABLE_REACT_CRUD_VIEWS)) {
Copy link
Member Author

@suddjian suddjian Mar 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept this logic consistent with permanently enabling the flag, but the logic doesn't look quite right to me. Shouldn't we be rendering with react instead of location.replaceing when react crud is enabled?

@rusackas rusackas added v2.0 risk:breaking-change Issues or PRs that will introduce breaking changes labels Mar 17, 2022
@codecov
Copy link

codecov bot commented Mar 17, 2022 •
edited
Loading

Codecov Report

Merging #19231 (8c04eb9) into master (48a12ad) will decrease coverage by 0.23%.
The diff coverage is 82.60%.

❗ Current head 8c04eb9 differs from pull request most recent head 2d114e5. Consider uploading reports for the commit 2d114e5 to get more accurate results

@@            Coverage Diff             @@
##           master   #19231      +/-   ##
==========================================
- Coverage   66.77%   66.53%   -0.24%     
==========================================
  Files        1670     1670              
  Lines       64385    64376       -9     
  Branches     6501     6498       -3     
==========================================
- Hits        42994    42835     -159     
- Misses      19707    19858     +151     
+ Partials     1684     1683       -1
Flag Coverage Δ
javascript 51.34% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
...erset-frontend/src/SqlLab/components/App/index.jsx 55.55% <0.00%> (+3.17%) ⬆️
superset-frontend/src/views/routes.tsx 56.25% <ø> (+1.70%) ⬆️
superset/config.py 91.82% <ø> (ø)
superset/connectors/sqla/views.py 63.67% <ø> (-0.34%) ⬇️
superset/views/alerts.py 83.51% <0.00%> (ø)
superset/views/annotations.py 81.96% <ø> (+4.69%) ⬆️
superset/views/chart/views.py 89.74% <ø> (+1.64%) ⬆️
superset/views/core.py 75.87% <ø> (+0.10%) ⬆️
superset/views/css_templates.py 96.66% <ø> (+5.75%) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48a12ad...2d114e5. Read the comment docs.

suddjian
suddjian commented Mar 17, 2022
View reviewed changes
tests/integration_tests/core_tests.py Outdated
@@ -429,6 +429,7 @@ def test_slices(self):
self.assertEqual(resp.status_code, 200)

def test_tablemodelview_list(self):
pytest.skip("Depends on ENABLE_REACT_CRUD_VIEWS=False")
Copy link
Member Author

@suddjian suddjian Mar 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm skipping these and requesting Preset QA to help with replacing the lost test coverage.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's any real loss of coverage here. ENABLE_REACT_CRUD_VIEWS=True has been the case for most large deployment of superset so far, so these test are just covering functionality that no one is using. The api tests and js tests provide decent coverage for the new crud view, imo.

@suddjian suddjian merged commit 97abc28 into apache:master Mar 18, 2022
@diegomedina248 diegomedina248 mentioned this pull request Jan 3, 2023
Merged
9 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nytai nytai nytai approved these changes

@john-bodley john-bodley Awaiting requested review from john-bodley john-bodley is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io risk:breaking-change Issues or PRs that will introduce breaking changes size/XL 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2.0] Remove ENABLE_REACT_CRUD_VIEWS flag, and sweep up old code
5 participants
@suddjian @nytai @mistercrunch @rusackas @michael-s-molina