Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate /superset/search_queries to API v1 #22579

Conversation

diegomedina248
Copy link
Contributor

@diegomedina248 diegomedina248 commented Jan 3, 2023

SUMMARY

Continuing the effort on deprecating all /superset/ REST API endpoints
Removes the QuerySearch component since it's no longer used (functionality removed in #19231)
Deprecates /search_queries

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@diegomedina248 diegomedina248 changed the title dm/sc42042/migrate superset search queries to api v1 chore: Migrate /superset/search_queries to API v1 Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #22579 (ceab1e9) into master (a7a4561) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #22579      +/-   ##
==========================================
- Coverage   66.91%   66.90%   -0.02%     
==========================================
  Files        1851     1858       +7     
  Lines       70709    70940     +231     
  Branches     7766     7756      -10     
==========================================
+ Hits        47316    47459     +143     
- Misses      21371    21455      +84     
- Partials     2022     2026       +4     
Flag Coverage Δ
hive 52.47% <100.00%> (+0.01%) ⬆️
javascript 53.73% <ø> (-0.13%) ⬇️
mysql 77.99% <100.00%> (+0.03%) ⬆️
postgres 78.06% <100.00%> (+0.03%) ⬆️
presto ?
python 81.20% <100.00%> (-0.07%) ⬇️
sqlite 76.44% <100.00%> (-0.06%) ⬇️
unit 51.46% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 75.00% <100.00%> (+0.01%) ⬆️
...rontend/src/components/DeprecatedSelect/styles.tsx 52.83% <0.00%> (-28.31%) ⬇️
...nents/DeprecatedSelect/WindowedSelect/windowed.tsx 54.54% <0.00%> (-18.19%) ⬇️
...c/components/DeprecatedSelect/DeprecatedSelect.tsx 41.33% <0.00%> (-12.00%) ⬇️
superset/db_engine_specs/presto.py 81.72% <0.00%> (-6.31%) ⬇️
superset/databases/commands/update.py 75.86% <0.00%> (-4.14%) ⬇️
...rontend/src/SqlLab/components/QueryTable/index.tsx 66.66% <0.00%> (-3.51%) ⬇️
...et-frontend/src/components/TableView/TableView.tsx 80.70% <0.00%> (-1.76%) ⬇️
superset/models/sql_lab.py 73.22% <0.00%> (-1.58%) ⬇️
superset/databases/commands/test_connection.py 97.43% <0.00%> (-1.24%) ⬇️
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@EugeneTorap
Copy link
Contributor

@dpgaspar Can we merge it?

@rusackas rusackas merged commit 44c9cf4 into apache:master Jan 11, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants