-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
other: Blossom metric fields for dataset API column selection #20732
other: Blossom metric fields for dataset API column selection #20732
Conversation
@@ -162,7 +163,18 @@ class DatasetRestApi(BaseSupersetModelRestApi): | |||
"columns.type", | |||
"columns.uuid", | |||
"columns.verbose_name", | |||
"metrics", | |||
"metrics", # TODO(john-bodley): Deprecate in 3.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensures backwards compatibility, i.e., non-breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the harm of keeping them both?
Codecov Report
@@ Coverage Diff @@
## master #20732 +/- ##
=======================================
Coverage 66.36% 66.36%
=======================================
Files 1754 1754
Lines 66673 66673
Branches 7049 7049
=======================================
Hits 44249 44249
Misses 20627 20627
Partials 1797 1797
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SUMMARY
Like for columns, this PR enables one to select specific metric fields in the dataset API.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI and tested in the Swagger UI, i.e., tested the GET
/api/v1/dataset/{pk}
RESTful API endpoint with the following query:Also confirmed that,
still works for backwards compatibility and,
only returns the metric ID, i.e., the
metrics
column is superseded by themetrics.id
column, which is consistent from a deprecation standpoint.ADDITIONAL INFORMATION