-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove previously deprecated dataset metrics column from RESTful API #24401
chore: Remove previously deprecated dataset metrics column from RESTful API #24401
Conversation
@@ -163,7 +163,6 @@ class DatasetRestApi(BaseSupersetModelRestApi): | |||
"columns.type", | |||
"columns.uuid", | |||
"columns.verbose_name", | |||
"metrics", # TODO(john-bodley): Deprecate in 3.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment was wrong, i.e., it should have said "remove" as opposed to "deprecate".
Codecov Report
@@ Coverage Diff @@
## master #24401 +/- ##
==========================================
+ Coverage 68.90% 68.95% +0.04%
==========================================
Files 1903 1903
Lines 74070 74070
Branches 8110 8110
==========================================
+ Hits 51041 51077 +36
+ Misses 20917 20881 -36
Partials 2112 2112
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
Following up on an action item from #20732 removing a column (which was previously blossomed and slated for removal in Superset 3.0).
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION