chore: Remove previously deprecated dataset metrics column from RESTful API #24401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
commented
Jun 14, 2023
| @@ -163,7 +163,6 @@ class DatasetRestApi(BaseSupersetModelRestApi): | |||
| "columns.type", | |||
| "columns.uuid", | |||
| "columns.verbose_name", | |||
| "metrics", # TODO(john-bodley): Deprecate in 3.0. | |||
There was a problem hiding this comment.
This comment was wrong, i.e., it should have said "remove" as opposed to "deprecate".
john-bodley
changed the title
Codecov Report
@@ Coverage Diff @@
## master #24401 +/- ##
==========================================
+ Coverage 68.90% 68.95% +0.04%
==========================================
Files 1903 1903
Lines 74070 74070
Branches 8110 8110
==========================================
+ Hits 51041 51077 +36
+ Misses 20917 20881 -36
Partials 2112 2112
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eschutho
added
the
risk:breaking-change
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Following up on an action item from #20732 removing a column (which was previously blossomed and slated for removal in Superset 3.0).
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION