Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 2nd try - simplify python dependencies #27505

Merged
merged 10 commits into from
Mar 19, 2024

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Mar 14, 2024

Keeping some of the good ideas from #27465 while putting that one on hold.

What's happening in this PR?

  • keep pip-compile-multi, but go down to two bundles base.in and development.in, converging all of testing.in, docker.in, integration.in and local.in into development.in
  • create a github reusable action .github/actions/setup-backend/action.yml for python/backend setup

@github-actions github-actions bot added doc Namespace | Anything related to documentation github_actions Pull requests that update GitHub Actions code labels Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.62%. Comparing base (16fcdb1) to head (731d5fd).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27505      +/-   ##
==========================================
+ Coverage   67.39%   69.62%   +2.23%     
==========================================
  Files        1909     1909              
  Lines       74736    74739       +3     
  Branches     8326     8326              
==========================================
+ Hits        50368    52040    +1672     
+ Misses      22318    20649    -1669     
  Partials     2050     2050              
Flag Coverage Δ
mysql 78.02% <ø> (+0.01%) ⬆️
postgres 78.14% <ø> (-0.01%) ⬇️
python 82.91% <ø> (+4.62%) ⬆️
sqlite 77.57% <ø> (-0.01%) ⬇️
unit 56.65% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Keeping some of the good ideas from
#27404, but keeping
pip-compile-multi

What's left here?
- keep pip-compile-multi, but bring things down to only base.txt and
  development.txt
- reusable/simplified .github/actions/setup-backend/action.yml
Copy link
Member

@craig-rueda craig-rueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But do we know if this could potentially break someone's deployment if they were relying on the dev dependencies for production? I'm thinking maybe the bigquery or oauth drivers.

@mistercrunch
Copy link
Member Author

I added a note in UGPRADING.md, but would love to get @john-bodley 's blessing before merging this one

@eschutho
Copy link
Member

Great, or rather, even with the notes in UPGRADING.md, would this break semver if this is released in 4.1 for example?

@mistercrunch
Copy link
Member Author

I don't think we should treat requirements/* as a public interface. Maybe, just maybe, we should treat requirements/base.txt as sensitive (renaming/deleting is would likely break some things somewhere).

I could be great to define the things or type of things we want to treat as a public interface for semver purposes and beyond. I'd argue that pinned deps shouldn't make that list.

Now with the pinned reqs keeping the package together that's a bit different, though that's why I'm trying to get back to a place where the pinned requirements would not be vital.

@mistercrunch
Copy link
Member Author

Ok, merging this as I have other improvements lined up

@mistercrunch mistercrunch merged commit 56a6660 into master Mar 19, 2024
28 checks passed
@mistercrunch mistercrunch deleted the kill-pip-compile-multi-nogo branch March 19, 2024 01:39
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Namespace | Anything related to documentation github_actions Pull requests that update GitHub Actions code size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants