Fix(eos_designs): WAN Exclude interface IP address from direct internet-exit NAT ACL #4096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4096
# Activate the virtual environment
source test-avd-pr-4096/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ayushmittal-arista/ayush-avd.git@fixie#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ayushmittal-arista/ayush-avd.git#/ansible_collections/arista/avd/,fixie --force
# Optional: Install AVD examples
cd test-avd-pr-4096
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
state: CI Updated
ClausHolbechArista
changed the title
...lections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/cv-pathfinder-edge1.cfg
Outdated
Show resolved
Hide resolved
ClausHolbechArista
requested changes
Jun 11, 2024
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/utils.py
Outdated
Show resolved
Hide resolved
..._collections/arista/avd/roles/eos_designs/python_modules/network_services/ip_access_lists.py
Outdated
Show resolved
Hide resolved
ClausHolbechArista
added
one approval
ClausHolbechArista
requested changes
Jun 12, 2024
..._collections/arista/avd/roles/eos_designs/python_modules/network_services/ip_access_lists.py
Outdated
Show resolved
Hide resolved
|
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
..._collections/arista/avd/roles/eos_designs/python_modules/network_services/ip_access_lists.py
Outdated
Show resolved
Hide resolved
..._collections/arista/avd/roles/eos_designs/python_modules/network_services/ip_access_lists.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/misc.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/utils.py
Outdated
Show resolved
Hide resolved
ayushmittal-arista
force-pushed
the
fixie
branch
from
12600d9
to
69572f5
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ayushmittal-arista
force-pushed
the
fixie
branch
2 times, most recently
from
a1fed96
to
ab9bdfb
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ayushmittal-arista
force-pushed
the
fixie
branch
from
ab9bdfb
to
e1049f2
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
removed
the
role: eos_designs
ayushmittal-arista
force-pushed
the
fixie
branch
from
a126f7c
to
6d563c9
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ayushmittal-arista
force-pushed
the
fixie
branch
from
6d563c9
to
a0f957a
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
python-avd/pyavd/_eos_designs/structured_config/network_services/ip_access_lists.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/utils.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Claus Holbech <[email protected]>
ClausHolbechArista
approved these changes
Jul 2, 2024
gmuloc
approved these changes
Jul 2, 2024
This was referenced Jul 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
ALLOW_ALLtoIE-DIRECT-NAT-ACLdeny iprule for all interfaces for all direct ie policies on the router in the ACL, so that traffic originating from these ip address is not natted again.Related Issue(s)
Fixes #4086
Component(s) name
arista.avd.eos-designsHow to test
molecule
Checklist
User Checklist
Repository Checklist