Fix(eos_designs)!: BGP vlan config should not have redistribute igmp when belonging to a VRF with evpn multicast

ansible_collections/arista/avd/docs/porting-guides/5.x.x.md

@@ -0,0 +1,23 @@
+---
+# This title is used for search results
+title: Porting Guide for Ansible AVD 5.x.x
+---
+<!--
+  ~ Copyright (c) 2023-2024 Arista Networks, Inc.
+  ~ Use of this source code is governed by the Apache License 2.0
+  ~ that can be found in the LICENSE file.
+  -->
+
+# Porting Guide for Ansible AVD 5.x.x
+
+Major releases of AVD can contain breaking changes. The porting guide addresses how to update your inventory
+and playbooks to be compatible with new default behaviors and changed data models when upgrading from AVD 3.x versions.
+
+Users of `eos_designs` do not have to consider the changes in `eos_cli_config_gen`, since those adaptions are
+built into `eos_designs`.
+
+## Changes to role `arista.avd.eos_designs`
+
+### Redistribute IGMP
+
+Removing redistribute igmp configuration for a BGP svi/vlan belonging to a VRF with EVPN multicast.

ansible_collections/arista/avd/docs/release-notes/5.x.x.md

@@ -0,0 +1,24 @@
+---
+# This title is used for search results
+title: Release Notes for AVD 5.x.x
+---
+<!--
+  ~ Copyright (c) 2023-2024 Arista Networks, Inc.
+  ~ Use of this source code is governed by the Apache License 2.0
+  ~ that can be found in the LICENSE file.
+  -->
+
+# Release Notes for AVD 5.x.x
+
+- Documentation for AVD version `5.x.x` [available here](https://www.avd.sh/en/stable/)
+
+<!-- Release notes generated using configuration in .github/release.yml at devel -->
+## Release 5.0.0
+
+### Breaking or behavioral changes in eos_designs
+
+Breaking changes may require modifications to the inventory or playbook.
+
+#### Removed redistribute igmp from BGP vlan config belonging to a VRF with evpn multicast
+
+Having redistribute igmp configured for a BGP svi/vlan belonging to a VRF with EVPN multicast causes conflicts in the control-plane.

ansible_collections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/EVPN-MULTICAST-DISABLED.cfg

@@ -520,19 +520,16 @@ router bgp 65106
    vlan 1
       rd 192.168.255.8:10001
       route-target both 10001:10001
-      redistribute igmp
       redistribute learned
    !
    vlan 110
       rd 192.168.255.8:10110
       route-target both 10110:10110
-      redistribute igmp
       redistribute learned
    !
    vlan 111
       rd 192.168.255.8:10111
       route-target both 10111:10111
-      redistribute igmp
       redistribute learned
    !
    vlan 130
@@ -563,13 +560,11 @@ router bgp 65106
    vlan 2
       rd 192.168.255.8:10002
       route-target both 10002:10002
-      redistribute igmp
       redistribute learned
    !
    vlan 210
       rd 192.168.255.8:10210
       route-target both 10210:10210
-      redistribute igmp
       redistribute learned
    !
    vlan 211
@@ -632,7 +627,6 @@ router bgp 65106
    vlan 3
       rd 192.168.255.8:10003
       route-target both 10003:10003
-      redistribute igmp
       redistribute learned
    !
    vlan 310

ansible_collections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/EVPN-MULTICAST-L3LEAF2A.cfg

@@ -591,19 +591,16 @@ router bgp 65103
    vlan 1
       rd 192.168.255.5:10001
       route-target both 10001:10001
-      redistribute igmp
       redistribute learned
    !
    vlan 110
       rd 192.168.255.5:10110
       route-target both 10110:10110
-      redistribute igmp
       redistribute learned
    !
    vlan 111
       rd 192.168.255.5:10111
       route-target both 10111:10111
-      redistribute igmp
       redistribute learned
    !
    vlan 130
@@ -634,13 +631,11 @@ router bgp 65103
    vlan 2
       rd 192.168.255.5:10002
       route-target both 10002:10002
-      redistribute igmp
       redistribute learned
    !
    vlan 210
       rd 192.168.255.5:10210
       route-target both 10210:10210
-      redistribute igmp
       redistribute learned
    !
    vlan 211
@@ -703,7 +698,6 @@ router bgp 65103
    vlan 3
       rd 192.168.255.5:10003
       route-target both 10003:10003
-      redistribute igmp
       redistribute learned
    !
    vlan 310

ansible_collections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/EVPN-MULTICAST-L3LEAF3A.cfg

@@ -613,19 +613,16 @@ router bgp 65104
    vlan 1
       rd 192.168.255.6:10001
       route-target both 10001:10001
-      redistribute igmp
       redistribute learned
    !
    vlan 110
       rd 192.168.255.6:10110
       route-target both 10110:10110
-      redistribute igmp
       redistribute learned
    !
    vlan 111
       rd 192.168.255.6:10111
       route-target both 10111:10111
-      redistribute igmp
       redistribute learned
    !
    vlan 130
@@ -656,13 +653,11 @@ router bgp 65104
    vlan 2
       rd 192.168.255.6:10002
       route-target both 10002:10002
-      redistribute igmp
       redistribute learned
    !
    vlan 210
       rd 192.168.255.6:10210
       route-target both 10210:10210
-      redistribute igmp
       redistribute learned
    !
    vlan 211
@@ -725,7 +720,6 @@ router bgp 65104
    vlan 3
       rd 192.168.255.6:10003
       route-target both 10003:10003
-      redistribute igmp
       redistribute learned
    !
    vlan 310

ansible_collections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/EVPN-MULTICAST-L3LEAF3B.cfg

@@ -613,19 +613,16 @@ router bgp 65105
    vlan 1
       rd 192.168.255.7:10001
       route-target both 10001:10001
-      redistribute igmp
       redistribute learned
    !
    vlan 110
       rd 192.168.255.7:10110
       route-target both 10110:10110
-      redistribute igmp
       redistribute learned
    !
    vlan 111
       rd 192.168.255.7:10111
       route-target both 10111:10111
-      redistribute igmp
       redistribute learned
    !
    vlan 130
@@ -656,13 +653,11 @@ router bgp 65105
    vlan 2
       rd 192.168.255.7:10002
       route-target both 10002:10002
-      redistribute igmp
       redistribute learned
    !
    vlan 210
       rd 192.168.255.7:10210
       route-target both 10210:10210
-      redistribute igmp
       redistribute learned
    !
    vlan 211
@@ -725,7 +720,6 @@ router bgp 65105
    vlan 3
       rd 192.168.255.7:10003
       route-target both 10003:10003
-      redistribute igmp
       redistribute learned
    !
    vlan 310

ansible_collections/arista/avd/molecule/eos_designs_unit_tests/intended/structured_configs/EVPN-MULTICAST-DISABLED.yml

@@ -283,7 +283,6 @@ router_bgp:
       - 10110:10110
     redistribute_routes:
     - learned
-    - igmp
   - id: 111
     tenant: Tenant_A
     rd: 192.168.255.8:10111
@@ -292,7 +291,6 @@ router_bgp:
       - 10111:10111
     redistribute_routes:
     - learned
-    - igmp
   - id: 210
     tenant: Tenant_A
     rd: 192.168.255.8:10210
@@ -301,7 +299,6 @@ router_bgp:
       - 10210:10210
     redistribute_routes:
     - learned
-    - igmp
   - id: 211
     tenant: Tenant_A
     rd: 192.168.255.8:10211
@@ -360,7 +357,6 @@ router_bgp:
       - 10001:10001
     redistribute_routes:
     - learned
-    - igmp
   - id: 2
     tenant: Tenant_B
     rd: 192.168.255.8:10002
@@ -369,7 +365,6 @@ router_bgp:
       - 10002:10002
     redistribute_routes:
     - learned
-    - igmp
   - id: 3
     tenant: Tenant_B
     rd: 192.168.255.8:10003
@@ -378,7 +373,6 @@ router_bgp:
       - 10003:10003
     redistribute_routes:
     - learned
-    - igmp
   - id: 4
     tenant: Tenant_B
     rd: 192.168.255.8:10004

ansible_collections/arista/avd/molecule/eos_designs_unit_tests/intended/structured_configs/EVPN-MULTICAST-L3LEAF2A.yml

@@ -292,7 +292,6 @@ router_bgp:
       - 10110:10110
     redistribute_routes:
     - learned
-    - igmp
   - id: 111
     tenant: Tenant_A
     rd: 192.168.255.5:10111
@@ -301,7 +300,6 @@ router_bgp:
       - 10111:10111
     redistribute_routes:
     - learned
-    - igmp
   - id: 210
     tenant: Tenant_A
     rd: 192.168.255.5:10210
@@ -310,7 +308,6 @@ router_bgp:
       - 10210:10210
     redistribute_routes:
     - learned
-    - igmp
   - id: 211
     tenant: Tenant_A
     rd: 192.168.255.5:10211
@@ -369,7 +366,6 @@ router_bgp:
       - 10001:10001
     redistribute_routes:
     - learned
-    - igmp
   - id: 2
     tenant: Tenant_B
     rd: 192.168.255.5:10002
@@ -378,7 +374,6 @@ router_bgp:
       - 10002:10002
     redistribute_routes:
     - learned
-    - igmp
   - id: 3
     tenant: Tenant_B
     rd: 192.168.255.5:10003
@@ -387,7 +382,6 @@ router_bgp:
       - 10003:10003
     redistribute_routes:
     - learned
-    - igmp
   - id: 4
     tenant: Tenant_B
     rd: 192.168.255.5:10004

ansible_collections/arista/avd/molecule/eos_designs_unit_tests/intended/structured_configs/EVPN-MULTICAST-L3LEAF3A.yml

@@ -298,7 +298,6 @@ router_bgp:
       - 10110:10110
     redistribute_routes:
     - learned
-    - igmp
   - id: 111
     tenant: Tenant_A
     rd: 192.168.255.6:10111
@@ -307,7 +306,6 @@ router_bgp:
       - 10111:10111
     redistribute_routes:
     - learned
-    - igmp
   - id: 210
     tenant: Tenant_A
     rd: 192.168.255.6:10210
@@ -316,7 +314,6 @@ router_bgp:
       - 10210:10210
     redistribute_routes:
     - learned
-    - igmp
   - id: 211
     tenant: Tenant_A
     rd: 192.168.255.6:10211
@@ -375,7 +372,6 @@ router_bgp:
       - 10001:10001
     redistribute_routes:
     - learned
-    - igmp
   - id: 2
     tenant: Tenant_B
     rd: 192.168.255.6:10002
@@ -384,7 +380,6 @@ router_bgp:
       - 10002:10002
     redistribute_routes:
     - learned
-    - igmp
   - id: 3
     tenant: Tenant_B
     rd: 192.168.255.6:10003
@@ -393,7 +388,6 @@ router_bgp:
       - 10003:10003
     redistribute_routes:
     - learned
-    - igmp
   - id: 4
     tenant: Tenant_B
     rd: 192.168.255.6:10004