Support Widget display on Categories Page and Fix Text Color using textContrastClass #50
Conversation
…tom Html Widget, Afrux Forum Widgets
…black font color depending on the color of the tag and amend the style of the sub heading with filter brightness for different color contrast
|
For afrux left sidebar top and left sidebar bottom to display correctly within Categories page, the PR afrux/forum-widgets-core#17 needs to be merged. But header, footer, and right widget will display correctly without the PR. |
|
Working on fixing dark mode, will remove the workaround as this causes issues. Will also remove filter brightness for just applying styling. |
… match with forum.js Added 2 style theming for both parent and child tags
| ->serializeToForum('categories.childBareIcon', 'askvortsov-categories.child-bare-icon', 'boolval', true), | ||
| ->serializeToForum('categories.childBareIcon', 'askvortsov-categories.child-bare-icon', 'boolval', true) | ||
| ->serializeToForum('categories.widgetHeader', 'askvortsov-categories.widget-header', 'boolval', false) | ||
| ->serializeToForum('categories.widgetRight', 'askvortsov-categories.widget-right', 'boolval', false) |
There was a problem hiding this comment.
Why not default these to true? If someone has installed a widget extension, presumably they want widgets?
There was a problem hiding this comment.
Not entirely, I though it was better to turn them off by default with the original categories page. No one seems to have complained about not having widgets on the page. The original didn't have header, footer or right side widget. Only there was a bug for allowing the widget to show on the left sidebar, which I accidently fixed. This PR was to make it almost like before, but with options
| })} | ||
| </ol> | ||
|
|
||
| {cloud.length ? <div className="TagCloud">{cloud.map((tag) => [tagLabel(tag, { link: true }), ' '])}</div> : ''} | ||
| </div>, | ||
| 50 | ||
| ); | ||
|
|
||
| // Only check for widget for the right if enable in the settings | ||
| if (app.forum.attribute('categories.widgetRight')) { |
There was a problem hiding this comment.
Is there no way for the widgets plugin to provide an API for reliably getting it's widgets? Or for it to extend this plugin?
There was a problem hiding this comment.
Well the plugin doesn't have option to hide or show widget on pages, I've provided a toggle to give admin the choice of showing what is needed for their categories page. Some people have them as their main page, while I don't have it as the mainpage. But the widget is useful else where on the website.
| items.add('icon', <span className="TagCategory-icon">{this.iconItems().toArray()}</span>, 100); | ||
| const children = this.isChild ? [] : sortTags(this.tag.children() || []); | ||
| let style: Record<string, unknown> = {}; | ||
| if (this.isChild) { |
There was a problem hiding this comment.
This "style building" code seems to be repeated; could you extract it into a helper function?
| @@ -12,16 +12,30 @@ askvortsov-categories: | |||
| parent_remove_stats: Hide stats for top-level tags? | |||
| parent_remove_last_discussion: Hide most recent discussions for top-level tags? | |||
| small_forum_optimized: Optimize for small forums? | |||
| enable_primary_tag_color: Enable Primary Tag Color? | |||
There was a problem hiding this comment.
Why don't we always want to enable tag colors?
There was a problem hiding this comment.
I've shown examples of the theme, which can give admin the choice of having it all minimalistic with the dark and light support.
|
Theme Choices Example
Please note that Child Tag 4 has no color assigned, it's left as '[empty]' for testing, I will work on @askvortsov1 concerns. It does need refactoring in some areas. But I'm trying to work on datlechin/flarum-tag-passwords#11 to hide protected discussion and fix the discussion protection within this first. |
…ction. POSITION_ANY = No position check POSITION_FIRST = First container only POSITION_AFTER_FIRST = After the first container
…t were last poster
Added new settings to enable or disable different sections of widgets
Fix #25 Using textContrastClass and applying filter for sub heading contrast
