Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes and better restrictions for protected tags #11

Merged
merged 4 commits into from
May 2, 2024

Conversation

Yippy
Copy link
Contributor

@Yippy Yippy commented May 1, 2024

Fix CCS Issue with hidden protected tag
fix css issue

Fix Error with widget added, which shift position of side navigation tags
error with widgets in sidebar

Improve Tags Page
tags page improvements

Restrict Protect Tags being displayed within Discussion List
discussion list restriction

Yippy added 4 commits May 1, 2024 19:32
…children isn't available.

Fix protection tag should be hidden for Tags Page for secondary tags. Cloud function used for TagsPage
Fix child tag being shown on TagsPage if they should be hidden from view
Fix lastDiscussion for tag, showing protected tag
Added Protected view for DiscussionList, this can be hidden or displayed using the new settings options
@Yippy
Copy link
Contributor Author

Yippy commented May 1, 2024

Forgot to mention that User Profile Page discussion list is also protected
user profile discussion list is protected

Though User Profile Post still display protected tags posts, which I will work on fixing

@Yippy
Copy link
Contributor Author

Yippy commented May 1, 2024

This PR will fix #6 for people that uses child tag that are protected, and forgets to enable 'Hide from All Discussions' within the editing of the Tag

Copy link
Owner

@datlechin datlechin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

@datlechin datlechin merged commit 984a384 into datlechin:main May 2, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants