-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to search for elements #77
Comments
Idea / user feedback: Below search results maybe also show results from opensymbols.org |
Also see discussion #239 |
I've just released a new version to grid.asterics.eu/latest/. Changes / new features:
To do / open for discussion:
Please test and comment. @arasaac-dga @jamjolu @tiekoide @deinhofer @sabicalija @msantos-87 |
Hi Benjamin,
I like the search feature very much, but it is doing some odd things:
If (I am using Quick Say 20) I search for the string* fast *I see the paths
to both the adjective *fast* and 2 references to the word break*fast.*
If I click the symbol, I am taken to the element and grid where the string
is found. The element is flashing.
If I click the string at the end of the search path, I am being led by
flashing elements through the path to the destination element. But, that
does not happen. The flashing elements are not leading me correctly to the
destination elements - I tried a few common browsers. Am I mistaken?
The path shown in the search modal is always correct.
Could there be a choice of the Global Grid with and without the search
function?
Just some thoughts,
jl
…On Thu, Dec 14, 2023 at 9:50 AM Benjamin Klaus ***@***.***> wrote:
I've just released a new version to grid.asterics.eu/latest/.
Changes / new features:
- Ctrl + F on the keyboard opens the search modal in normal grid view, edit
view and manage grids view
- correctly showing the path to the element in search results
- click on the image directly shows the element, click on the path
highlights the path, starting from home grid:
grafik.png (view on web)
<https://github.com/asterics/AsTeRICS-Grid/assets/2537025/6f68aa43-2c1f-43b7-b73d-706e0bfb2357>
- keyboard shortcuts: Enter directly shows first search result, Ctrl +
Enter shows the path the the first search result
- always shows shortest path to the element, if multiple paths
- tried to optimize performance for big grid configurations, thanks to
@jamjolu <https://github.com/jamjolu> for your quite complex test case
(Quick_Say20) ;)
- added possibilities to open search dialog in action Navigate to
other grid, including options to directly search for collected or
custom text:
grafik.png (view on web)
<https://github.com/asterics/AsTeRICS-Grid/assets/2537025/d08d5705-82fe-45cf-8cf4-35f50ea6bf2b>
- added search icon to the default global grid - get it by clicking
here in "Manage grids":
grafik.png (view on web)
<https://github.com/asterics/AsTeRICS-Grid/assets/2537025/312db9f7-4169-4ed9-9c50-bfc57c525679>
grafik.png (view on web)
<https://github.com/asterics/AsTeRICS-Grid/assets/2537025/470477cf-e02f-4403-811c-e9821773139a>
To do / open for discussion:
- currently there is no search button in manage grids and edit grid,
only the Ctrl + F is possible. Do we need a button there? Where? I
would assume that "power users" will quickly adapt to Ctrl + F and
don't need an additional button. If we need it, I think the only place to
add it would be within the "More" button.
- I think we would need an additional pictogram for searching, in the
same style as the others in the global grid, @arasaac-dga
<https://github.com/arasaac-dga>
- New strings in crowdin should be translated, @arasaac-dga
<https://github.com/arasaac-dga>
- Should all default gridsets be updated to contain the new global
grid?
Please test and comment. @arasaac-dga <https://github.com/arasaac-dga>
@jamjolu <https://github.com/jamjolu> @tiekoide
<https://github.com/tiekoide> @deinhofer <https://github.com/deinhofer>
@sabicalija <https://github.com/sabicalija> @msantos-87
<https://github.com/msantos-87>
—
Reply to this email directly, view it on GitHub
<#77 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF4D6ZSMG4Q75KERFB6VZLTYJMG2TAVCNFSM4THSJZOKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBVGU4TSMBVGY4Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Good morning, Benjamin. First of all, great job as always. Congrats!!!! We are going to reply to your questions and share the issues that we have found. TO DO / OPEN FOR DISCUSSION:
You can add too in More menú but we think it is more accessible in the position we have suggested.
We have made and upload one new pictogram here: https://arasaac.org/pictograms/es/39110/
Translated
We don't think that you must add the new search button in Global Grid. We are more comfortable with the actual global grid. Search option is only for advanced users. So it will not be commonly used by users and they have the upper button in the header to access this option. On the other hand Global Grid has many buttons and adds one more supposed less space for accumulated phrase. So, please come back to the old global grid version (of course with the new features for home and come back buttons). ISSUES: In general the search option works as expected in most of the searches but we have found some issues. We attach some videos to see them:
https://app.box.com/s/r1ml6alkqbo918tm2g40kzjf5zok4wim
https://app.box.com/s/vauckqff5ahgr71naeivs69do65o7s0jhttps://app.box.com/s/wnso4z438hf9gfz30zxjp01wpr0n6jkdhttps://app.box.com/s/wahpxuj1kp22hygxp1a41tz6bsbnscdvhttps://app.box.com/s/f6qsof8qmfyu3otbdimlixv5ylgbj07ohttps://app.box.com/s/leejqr392stn39e23h17pd6ifnbo5wjqhttps://app.box.com/s/rbksx7l38lqqp476uimx2l058borhcsj As you can see there are errors with the initial cell of the route that blinks continuously when you come back to the initial grid. The new options in "Navigate to" action work as expected. No problems detected. |
As an alternative to adding the search feature to the Global Grid, how
about including search as an available action for an element. That way
someone who wants the search feature on their Global Grid can add it
whenever they want.
jl
…On Fri, Dec 15, 2023 at 6:11 AM arasaac-dga ***@***.***> wrote:
Good morning, Benjamin. First of all, great job as always. Congrats!!!! We
are going to reply to your questions and share the issues that we have
found.
*TO DO / OPEN FOR DISCUSSION:*
1. *"Currently there is no search button in manage grids and edit
grid, only the Ctrl + F is possible. Do we need a button there Where? I
would assume that "power users" will quickly adapt to Ctrl + F and don't
need an additional button. If we need it, I think the only place to add it
would be within the "More" button. We have to think in tablet users too
where is impossible to use Ctr+F. So we need a search button al most in
Manage Grids page (in edit mode is enough with Ctrl+F). We atttach you the
poisition that we think is the best (addtionaly we have change the position
of number of grids that we think is more suitable)"*
search_button_position.jpg (view on web)
<https://github.com/asterics/AsTeRICS-Grid/assets/82500056/e3a44ce3-e736-4aaa-aa13-565614ef9c55>
You can add too in More menú but we think it is more accessible in the
position we have suggested.
1. *"I think we would need an additional pictogram for searching, in
the same style as the others in the global grid, @arasaac-dga
<https://github.com/arasaac-dga>"*
We have made and upload one new pictogram here:
https://arasaac.org/pictograms/es/39110/
1. *"New strings in crowdin should be translated, @arasaac-dga
<https://github.com/arasaac-dga>"*
Translated
1. "Should all default gridsets be updated to contain the new global
grid?"
We don't think that you must add the new search button in Global Grid. We
are more comfortable with the actual global grid. Search option is only for
advanced users. So it will not be commonly used by users and they have the
upper button in the header to access this option. On the other hand Global
Grid has many buttons and adds one more supposed less space for accumulated
phrase. So, please come back to the old global grid version (of course with
the new features for home and come back buttons).
*ISSUES:*
In general the search option works as expected in most of the searches but
we have found some issues. We attach some videos to see them:
1. In Edit Cell mode, when you press Ctrl+F the search dialog window
is placed behind the Edit Cell Window
https://app.box.com/s/r1ml6alkqbo918tm2g40kzjf5zok4wim
1. Using our ARASAAC Predefined Communicator we have found issues
searching elements placed in Core 50 grid when you use the option to follow
the route (with direct access there is no problem). As you can see always
go to the same pictogram and not the selected one (goes to "Se acabo").
https://app.box.com/s/vauckqff5ahgr71naeivs69do65o7s0j
https://app.box.com/s/wnso4z438hf9gfz30zxjp01wpr0n6jkd
https://app.box.com/s/wahpxuj1kp22hygxp1a41tz6bsbnscdv
https://app.box.com/s/f6qsof8qmfyu3otbdimlixv5ylgbj07o
https://app.box.com/s/leejqr392stn39e23h17pd6ifnbo5wjq
https://app.box.com/s/rbksx7l38lqqp476uimx2l058borhcsj
As you can see there are errors with the initial cell of the route that
blinks continuously when you come back to the initial grid.
The new options in "Navigate to" action work as expected. No problems
detected.
—
Reply to this email directly, view it on GitHub
<#77 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF4D6ZRMHH43EK3ENLJPAN3YJQV6TAVCNFSM4THSJZOKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBVG43TAMRQGU3Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@jamjolu Benjamin has added as sub-action inside "Navigation to other grid" action. Look the capture that Bejamin share with us. In "Navigation type" selecting "Open search dialog" you can assign this action to any cell you wish (with or without custom text). |
…event errors if there are duplicated grid ids, see #77
I've just released a new version to https://grid.asterics.eu/latest/
Thanks for finding this bug - it should be fixed.
Do you think many people will use the button or at all the search function within "Manage grids"? Or should we just provide the keyboard shortcut as now for power users? What about "edit grid view"?
OK, I've removed the search button from the default global grid again.
Now it's in the foreground - however I think it's a rare case that someone goes to the search dialog while editing an element.
I think it was the same issue also @jamjolu reported - should be resolved, please test. Fun fact: @jamjolu 's Quick Say 20 has a total of |
Hi Benjamin I just tested after the latest update: |
I've tested again in Firefox, it seems like it wasn't the latest version running there. Now everything works in all browsers for me, so I cannot reproduce the issue. |
After clearing cache and re-importing everything the step-by-step-function now works again on the Macbook, Android and iPad :) The full screen issue on the iPad remains, though: For Safari and Chrome it exits full screen when I want to search. For Firefox the full screen isn't working at all. All apps are updated. |
Yes, it's fixed
We are discussing again and we agree that perhaps the Search button is not needed in Manage Grid page. Thinking in people that edit boards from a tablet (with no keyboard) perhaps it would be more suitable in More menu as you initialy proposed (of Edit Grid page only, not in more menu of Manage Grids).
Thanks
Yes it's a rare cae but always is better that is in the correct position.
Yes, it works fine now.
|
Thanks, it works as expected.
Tested in Chrome, Firefox, Edge.
jl
…On Wed, Dec 20, 2023 at 5:21 AM arasaac-dga ***@***.***> wrote:
I've just released a new version to https://grid.asterics.eu/latest/
The flashing elements are not leading me correctly to the destination
elements
Thanks for finding this bug - it should be fixed.
Yes, it's fixed
You can add too in More menú but we think it is more accessible in the
position we have suggested.
Do you think many people will use the button or at all the search function
within "Manage grids"? Or should we just provide the keyboard shortcut as
now for power users? What about "edit grid view"?
We are discussing again and we agree that perhaps the Search button is not
needed in Manage Grid page. Thinking in people that edit boards from a
tablet (with no keyboard) perhaps it would be more suitable in More menu as
you initialy proposed (of Edit Grid page only, not in more menu of Manage
Grids).
So, please come back to the old global grid version (of course with the
new features for home and come back buttons).
OK, I've removed the search button from the default global grid again.
Thanks
In Edit Cell mode, when you press Ctrl+F the search dialog window is
placed behind the Edit Cell Window
Now it's in the foreground - however I think it's a rare case that someone
goes to the search dialog while editing an element.
Yes it's a rare cae but always is better that is in the correct position.
Using our ARASAAC Predefined Communicator we have found issues searching
elements placed in Core 50 grid when you use the option to follow the route
(with direct access there is no problem).
I think it was the same issue also @jamjolu <https://github.com/jamjolu>
reported - should be resolved, please test.
Yes, it works fine now.
Fun fact: @jamjolu <https://github.com/jamjolu> 's Quick Say 20 has a
total of 28038 possible paths to all other grids starting from the home
grid, I've further optimized performance, so that searches in this complex
network now take below 500ms.
—
Reply to this email directly, view it on GitHub
<#77 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF4D6ZSZJRGHPW4EOABD6ZLYKK33LAVCNFSM4THSJZOKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBWGQZDCOBXGU3Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks for the hint. I've tried it and could reproduce it. I assume that maybe Safari automatically stops fullscreen at showing the keyboard?! However if you "install" the app (add it to home screen and start it from there), for me staying in fullscreen and searching works. However if there's anything left to be done regarding this, please just open a new issue.
Ok, I'll add it there and then release everything to main version. |
User feedback: it would be nice to have a global search function in order to quickly find existing elements and the place/grid where it is.
Possibliy it's best to implement it somewhere in the Manage Grids view, and do this while also working on #14
The text was updated successfully, but these errors were encountered: