Linters fix

astroboyReloaded · Jan 24, 2024 · 5c99b05 · 5c99b05
1 parent ddbaaa7
commit 5c99b05
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 38 deletions.
diff --git a/assets/astroboyReloaded_CV.pdf b/assets/astroboyReloaded_CV.pdf
diff --git a/index.html b/index.html
@@ -82,7 +82,8 @@ <h1 class="playfair about-title" aria-label="About me.">About</h1>
           ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut
           aliquip ea eiusmod.
         </p>
-        <a href="#" class="btnBlue getCV poppins" download tabindex="15" aria-label="Enter here to get my CV.">Get my
+        <a href="./assets/astroboyReloaded_CV.pdf" class="btnBlue getCV poppins" download tabindex="15"
+          aria-label="Enter here to get my CV.">Get my
           CV<i class="download"></i></a>
       </div>
       <ul class="tech-cards-container poppins">
@@ -155,51 +156,48 @@ <h1 class="playfair" aria-label="Lets get started.">Get Started</h1>
       </form>
     </section>
     <footer>
-      <a href="#" class="open poppins" target="_blank" tabindex="21">Get my Resume</a>
+      <a href="https://docs.google.com/document/d/1sGZ6yxcJa1jLS59dCbatuG7NZ1vUlPIAJKK0h03SrC0/edit?usp=sharing"
+        rel="noopener" class="open poppins" target="_blank" tabindex="21">Get my Resume</a>
       <ul class="social-container">
         <li>
-          <a class="social-link" href="https://stackoverflow.com/users/18165300/alex-munoz" target="_blank"
-            tabindex="22">
+          <a class="social-link" rel="noopener" href="https://stackoverflow.com/users/18165300/alex-munoz"
+            target="_blank" tabindex="22">
             <i class="social-icon">
               <img src="./images/icons/stackoverflow.svg" alt="Stack Overflow" />
             </i>
           </a>
         </li>
         <li>
-          <a class="social-link" href="https://github.com/astroboyReloaded" target="_blank" tabindex="23">
+          <a class="social-link" rel="noopener" href="https://github.com/astroboyReloaded" target="_blank"
+            tabindex="23">
             <i class="social-icon">
               <img src="./images/icons/github-icon.svg" alt="GitHub" />
             </i>
           </a>
         </li>
         <li>
-          <a class="social-link" href="https://twitter.com/astroboyReload" target="_blank" tabindex="24">
+          <a class="social-link" rel="noopener" href="https://twitter.com/astroboyReload" target="_blank" tabindex="24">
             <i class="social-icon">
               <img src="./images/icons/twitter.svg" alt="Twitter" />
             </i>
           </a>
         </li>
         <li>
-          <a class="social-link" href="https://www.linkedin.com/in/astroboyreloaded/" target="_blank" tabindex="25">
+          <a class="social-link" rel="noopener" href="https://www.linkedin.com/in/astroboyreloaded/" target="_blank"
+            tabindex="25">
             <i class="social-icon">
               <img src="./images/icons/linkedin.svg" alt="Linkedin" />
             </i>
           </a>
         </li>
         <li>
-          <a class="social-link" href="#" target="_blank" tabindex="26">
+          <a class="social-link" rel="noopener" href="https://medium.com/@astroboy.reloaded" target="_blank"
+            tabindex="26">
             <i class="social-icon m">
               <img src="./images/icons/M-icon.svg" alt="M" />
             </i>
           </a>
         </li>
-        <li>
-          <a class="social-link" href="#" target="_blank" tabindex="27">
-            <i class="social-icon">
-              <img src="./images/icons/pnl-icon.svg" alt="PNL" />
-            </i>
-          </a>
-        </li>
       </ul>
     </footer>
   </main>

diff --git a/package-lock.json b/package-lock.json
diff --git a/scripts/works.js b/scripts/works.js
@@ -23,7 +23,7 @@ ${projectData.map((project) => `
     class="tech-container"
     aria-label="Technologies:${project.tech.map((t, i, a) => (t[i] === a.length - 1 ? t : ` ${t}`))}."
   >
-    ${project.tech.map(tech => `<li class="tech-item">${tech}</li>`).join('')}
+    ${project.tech.map((tech) => `<li class="tech-item">${tech}</li>`).join('')}
   </ul>
   <button
     class="btnBlue seeProjBtn"

diff --git a/styles.css b/styles.css
@@ -199,21 +199,21 @@ nav ul {
   margin-top: 9px;
 }
 
-#menu-toggle:checked+.menu-btn::before {
+#menu-toggle:checked + .menu-btn::before {
   margin-top: 0;
   transform: rotate(45deg);
 }
 
-#menu-toggle:checked+.menu-btn {
+#menu-toggle:checked + .menu-btn {
   background: rgba(255, 255, 255, 0);
 }
 
-#menu-toggle:checked+.menu-btn::after {
+#menu-toggle:checked + .menu-btn::after {
   margin-top: 0;
   transform: rotate(-45deg);
 }
 
-.menu-btn-container #menu-toggle:checked+.logo {
+.menu-btn-container #menu-toggle:checked + .logo {
   background: url('images/deco/mobile/menu-top.svg') no-repeat;
 }
 
@@ -246,8 +246,7 @@ nav ul {
   margin: 27px 0 0 -18px;
   width: 100vw;
   height: 53.333vw;
-  background:
-    url("images/deco/mobile/image_geometry-headline-mobile.svg") no-repeat;
+  background: url("images/deco/mobile/image_geometry-headline-mobile.svg") no-repeat;
   background-size: contain;
 }
 
@@ -265,16 +264,13 @@ nav ul {
 .project {
   display: flex;
   flex-direction: column;
+  width: 100%;
 }
 
 .project:focus {
   border: 2px solid var(--border);
 }
 
-.project {
-  width: 100%;
-}
-
 .project-image {
   width: 100%;
   height: 100%;
@@ -483,8 +479,7 @@ nav ul {
 }
 
 .frames {
-  background:
-    #e2505c url("images/deco/about/Frameworks.svg") 100% 100% no-repeat;
+  background: #e2505c url("images/deco/about/Frameworks.svg") 100% 100% no-repeat;
 }
 
 .skills {
@@ -585,8 +580,7 @@ footer {
   margin: 2rem 1rem;
   width: fit-content;
   padding-right: 45px;
-  background:
-    url("images/icons/open-in-new-window-icon-LightBlue.svg") 100% 50% no-repeat;
+  background: url("images/icons/open-in-new-window-icon-LightBlue.svg") 100% 50% no-repeat;
   transition: transform 300ms ease-in-out;
 }
 
@@ -737,7 +731,7 @@ footer {
     margin-top: 9vw;
   }
 
-  #works>h1 {
+  #works > h1 {
     grid-area: title;
     position: absolute;
     display: flex;
@@ -824,8 +818,7 @@ footer {
     top: 0.18vw;
     left: -0.05vw;
     width: 44.27vw;
-    background:
-      url("images/deco/desktop/work-right-deco.svg") bottom left no-repeat;
+    background: url("images/deco/desktop/work-right-deco.svg") bottom left no-repeat;
     background-size: contain;
   }
 
@@ -1024,7 +1017,7 @@ footer {
     justify-content: space-between;
   }
 
-  #about>div {
+  #about > div {
     display: flex;
     flex-direction: column;
     flex: 1;
@@ -1152,4 +1145,4 @@ footer {
     margin: 1rem;
     align-items: center;
   }
-}
+}