Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very damaged/truncated PE is reported as unsupported format #921

Closed
metthal opened this issue Feb 8, 2021 · 2 comments
Closed

Very damaged/truncated PE is reported as unsupported format #921

metthal opened this issue Feb 8, 2021 · 2 comments

Comments

@metthal
Copy link
Member

metthal commented Feb 8, 2021

We were previously reporting for a very damaged PE files that they are PEs with a loader errors. For example such file is 7c9435ecd691de2a53e0d4ca32f3ae57725a248fe3d86230efadefd131029eb2. As of right now, we are reporting it as an unsupported file format.

Don't have it confirmed but it seems like #812 might be a breaking point where regression was introduced. We'd like to reporting this as a very broken PE instead of unsupported file format.

@ladislav-zezula
Copy link
Contributor

I slightly changed the logic:

  • Before: The image loader in fileinfo set ldrError to LDR_ERROR_NTHEADER_OUT_OF_FILE and returned ERROR_INVALID_FILE
  • After: The image loader sets ldrError to LDR_ERROR_NTHEADER_OUT_OF_FILE and returns ERROR_NONE.

As result, the first phase check now recognizes the file as PE and the final status is LDR_ERROR_NTHEADER_OUT_OF_FILE.

#922
avast/retdec-regression-tests#83

s3rvac added a commit that referenced this issue Feb 11, 2021
s3rvac added a commit to avast/retdec-regression-tests that referenced this issue Feb 11, 2021
@s3rvac
Copy link
Member

s3rvac commented Feb 11, 2021

Fixed in #922.

@s3rvac s3rvac closed this as completed Feb 11, 2021
s3rvac added a commit that referenced this issue Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants