Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MzHeader and PeHeader classes in PELIB were replaced by ImageLoader class #812

Merged
merged 34 commits into from
Jul 21, 2020

Conversation

ladislav-zezula
Copy link
Contributor

No description provided.

Copy link
Collaborator

@PeterMatula PeterMatula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, the whole PE parsing is much better now.

In comments, there are few things I noticed. Not everything have to be fixed, some are just questions, or things to think about.

Some general remarks for newly written code (or major refactorization):

  • Use strongly typed enums as default. Use old enums only if there is some specific reason why not to use strong enums.
  • Initialize all class/struct members right at their declaration (e.g. type* whatever = nullptr;).
  • Initialize all local variables right at their declaration, even if their are later defined before used - the code might change later, and there might be a problem (e.g. type* whatever = nullptr;)
  • Initialize all ... = only those types, that do not have default constructors, so don't use something like this std::string str = "";
  • Long lines (and there are many in PeLib/Fileformat/Fileinfo/...) hurt my head. No need to refactor all the old code, by in the new code, try to keep lines under 80 chars. Set a nice red line in your IDE :-D Break all the lines that are longer.
    This is much nicer:
void DebugDirectory::read(
    ImageLoader & imageLoader, 
    std::vector<PELIB_IMG_DEBUG_DIRECTORY> & debugInfo, 
    std::uint32_t rva, 
    std::uint32_t size
)

than this:

void DebugDirectory::read(ImageLoader & imageLoader, std::vector<PELIB_IMG_DEBUG_DIRECTORY> & debugInfo, std::uint32_t rva, std::uint32_t size)

src/fileinfo/file_wrapper/pe_wrapper.cpp Outdated Show resolved Hide resolved
src/fileinfo/fileinfo.cpp Outdated Show resolved Hide resolved
src/pelib/ImageLoader.cpp Outdated Show resolved Hide resolved
src/pelib/ImageLoader.cpp Show resolved Hide resolved
src/pelib/ImageLoader.cpp Outdated Show resolved Hide resolved
@PeterMatula
Copy link
Collaborator

IDE with line break border. It is much nicer to have 2 or even 3 tabs side-by-side if the lines are short.
line-breaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants