-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MzHeader and PeHeader classes in PELIB were replaced by ImageLoader class #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterMatula
requested changes
Jul 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, the whole PE parsing is much better now.
In comments, there are few things I noticed. Not everything have to be fixed, some are just questions, or things to think about.
Some general remarks for newly written code (or major refactorization):
- Use strongly typed enums as default. Use old enums only if there is some specific reason why not to use strong enums.
- Initialize all class/struct members right at their declaration (e.g.
type* whatever = nullptr;
). - Initialize all local variables right at their declaration, even if their are later defined before used - the code might change later, and there might be a problem (e.g.
type* whatever = nullptr;
) - Initialize all ... = only those types, that do not have default constructors, so don't use something like this
std::string str = "";
- Long lines (and there are many in PeLib/Fileformat/Fileinfo/...) hurt my head. No need to refactor all the old code, by in the new code, try to keep lines under 80 chars. Set a nice red line in your IDE :-D Break all the lines that are longer.
This is much nicer:
void DebugDirectory::read(
ImageLoader & imageLoader,
std::vector<PELIB_IMG_DEBUG_DIRECTORY> & debugInfo,
std::uint32_t rva,
std::uint32_t size
)
than this:
void DebugDirectory::read(ImageLoader & imageLoader, std::vector<PELIB_IMG_DEBUG_DIRECTORY> & debugInfo, std::uint32_t rva, std::uint32_t size)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.