fix: @jsii/check-node crashes on loading with older node releases (#3588

)
aws · Jun 9, 2022 · a1582bf · a1582bf
1 parent de3fc03
commit a1582bf
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/packages/@jsii/check-node/src/constants.ts b/packages/@jsii/check-node/src/constants.ts
@@ -27,8 +27,6 @@ export class NodeRelease {
     // Past end-of-life releases
     new NodeRelease(13, { endOfLife: new Date('2020-06-01') }),
     new NodeRelease(15, { endOfLife: new Date('2021-06-01') }),
-
-    // Deprecated releases
     new NodeRelease(12, {
       endOfLife: new Date('2022-04-30'),
       supportedRange: '^12.7.0',

diff --git a/packages/@jsii/check-node/tsconfig.json b/packages/@jsii/check-node/tsconfig.json
@@ -1,9 +1,14 @@
 {
   "extends": "../../../tsconfig-base",
   "compilerOptions": {
+    "target": "es2018", // Needs to target older releases of node or else it'll crash on start when using those
     "outDir": "./lib",
     "rootDir": "./src",
   },
-  "include": ["src/**/*.ts"],
-  "exclude": ["jest.config.ts"],
+  "include": [
+    "src/**/*.ts"
+  ],
+  "exclude": [
+    "jest.config.ts"
+  ],
 }
diff --git a/packages/@jsii/runtime/webpack.config.js b/packages/@jsii/runtime/webpack.config.js
@@ -18,7 +18,7 @@ module.exports = {
     iife: false,
   },
   devtool: 'source-map',
-  target: 'node14.5',
+  target: 'node12', // Continue to target node 12 so that check-node does not fail to load on it.
   node: {
     global: false,
     __filename: false,