Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @jsii/check-node crashes on loading with older node releases #3588

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Jun 9, 2022

It was built with ES2020 target, which fails to load with Node 10 and 12 as
it makes use of the ?? syntax, which is not available in those releases.
Changing the TypeScript target so that code continues to load in older node
releases.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RomainMuller RomainMuller self-assigned this Jun 9, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 9, 2022
It was built with ES2020 target, which fails to load with Node 10 and 12 as
it makes use of the ?? syntax, which is not available in those releases.
Changing the TypeScript target so that code continues to load in older node
releases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant