-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jsii-diff): renaming a positional argument is a breaking change in Python #2937
base: main
Are you sure you want to change the base?
Conversation
…n Python Related: #2927
In languages such as Python (<3.8) and Ruby, positional parameters can be referred to using their names, making these names part of the function signature. In order to avoid enforing parameter name consistency on the TypeScript source, the `jsii` compiler will always use the root declaration's parameter names when emitting the `.jsii` assembly file. Related #2927
@RomainMuller any progress on this? |
7c847b6
to
27c610d
Compare
@RomainMuller do you think this has any chance of getting merged? I'm assuming the lack of progress is due to the high number of deprecations required on the CDK side. |
We are also consider alternate solutions to this... Quite frankly... it might be "easier" to wait for Python 3.7 EOL next June, as Python 3.8+ supports "positional-only" argument notation (using the |
Got it. But that would still be a breaking change, some folks may be using them as keyword arguments. |
Yeah... Nothing is ever that easy... we might be able to strategize around this however. |
Related: #2927
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.