Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jsii-diff): renaming a positional argument is a breaking change in Python #2937

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix(jsii-diff): renaming a positional argument is a breaking change in Python #2937

wants to merge 3 commits into from

Commits on Aug 4, 2021

  1. fix(jsii-diff): renaming a positional argument is a breaking change i… 

    …n Python

Related: #2927
    @RomainMuller
    RomainMuller committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    a996fe6 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2021

  1. feat: always use root signature parameter names 

    In languages such as Python (<3.8) and Ruby, positional parameters can
be referred to using their names, making these names part of the
function signature. In order to avoid enforing parameter name
consistency on the TypeScript source, the `jsii` compiler will always
use the root declaration's parameter names when emitting the `.jsii`
assembly file.

Related #2927
    @RomainMuller
    RomainMuller committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    c665b7e View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. Merge branch 'main' into rmuller/python-positional-args

    @RomainMuller
    RomainMuller committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    862d433 View commit details
    Browse the repository at this point in the history