Skip to content

v0.3.1.3 Credit trade signing history and commenting for fuel suppliers

Compare
Choose a tag to compare
@kuanfandevops kuanfandevops released this 04 Jul 00:05
· 1281 commits to master since this release

This minor release includes

PR #413 Credit Trade Signing History

We should now have a section in the Credit Trade where it shows who signed the proposal and who reviewed the proposal.

  • Added CreditTradeSigningHistory component
  • Added signatures and reviewed property in the Credit Trade
  • Restored the single quotes in CreditTradeHistory (was getting into an infinite loop if I try to import CreditTradeHistory into CreditTrade)
  • Removed Propose Trade permission from Government Director

PR #414 Add commenting for fuel suppliers

This pull request introduces the commenting feature for fuel suppliers.

  • Added natural key lookups for User, Role, Permission, Credit Trade Status, and Type to ease test fixture creation
  • Exhaustive testing suite to validate permissions are applied as specified by business logic
  • Created a new test fixture with more production-like government roles to test finer-grained permissions
  • Refactored commenting permissions to allow client and server to share the same logic (the server passes allowable commenting actions as part of a credit trade API response)
  • Tooltips/disabled statuses for action buttons when commenting mode is active

Data Migration and Fixture

The following migrations are included:

  • 0016_rename_comment.py
  • 0017_auto_20180628_2024.py
  • 0018_auto_20180703_1718.py

The fixture loaded is

  • roles_permissions.json (notes: one record is removed from this file, this is the reason why this file is listed here. The record has been removed from Test database manually.)

Implemented Trello Cards

Technical information

This release is deployed on Dev at June 29, 2018(PR#413 only) and July 03, 2018, deployed on test at July 03, 2018.