Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delivery-work does not read multi slash branch names #255

Closed
extsoft opened this issue Apr 13, 2020 · 1 comment
Closed

delivery-work does not read multi slash branch names #255

extsoft opened this issue Apr 13, 2020 · 1 comment
Labels

Comments

@extsoft
Copy link
Contributor

extsoft commented Apr 13, 2020

The bug

git elegant deliver-work incorrectly reads the name of the upstream branch if it contains at least one slash like feature/123.

Steps to reproduce

  1. git checkout -b feature/123
  2. git elegant deliver-work # first push
  3. git elegant deliver-work # next push

Expected behavior

The third command should update feature/123 branch in origin. Now, it pushes a new branch called 123 (so, feature/ is removed).

My environment

  • git --version: 2.26.0
  • bash --version: 3.2.57
  • OS: MacOS
extsoft added a commit that referenced this issue Apr 15, 2020
`git elegant deliver-work` incorrectly reads the name of the upstream
branch if it contains at least one slash like `feature/123`. This is
because the used pattern matching logic doesn't expect remote branch
names like `origin/feature/123`.

In order to solve it, the new `transformation` plugin is introduced. It
provides functions that parse remote branch names correctly. Now, the
plugin handles branch translation (mapping) for `deliver-work` command
as well as for `accept-work` and `obtain-work` in order to prevent
possible errors in the future.

#255
extsoft added a commit that referenced this issue Apr 15, 2020
`git elegant deliver-work` incorrectly reads the name of the upstream
branch if it contains at least one slash like `feature/123`. This is
because the used pattern matching logic doesn't expect remote branch
names like `origin/feature/123`.

In order to solve it, the new `transformation` plugin is introduced. It
provides functions that parse remote branch names correctly. Now, the
plugin handles branch translation (mapping) for `deliver-work` command
as well as for `accept-work` and `obtain-work` in order to prevent
possible errors in the future.

#255
@extsoft
Copy link
Contributor Author

extsoft commented Apr 15, 2020

Fixed since 0.18.1 release.

@extsoft extsoft closed this as completed Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant