Read multi slash branch names when deliver-work
#256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`git elegant deliver-work` incorrectly reads the name of the upstream branch if it contains at least one slash like `feature/123`. This is because the used pattern matching logic doesn't expect remote branch names like `origin/feature/123`. In order to solve it, the new `transformation` plugin is introduced. It provides functions that parse remote branch names correctly. Now, the plugin handles branch translation (mapping) for `deliver-work` command as well as for `accept-work` and `obtain-work` in order to prevent possible errors in the future. #255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git elegant deliver-workincorrectly reads the name of the upstreambranch if it contains at least one slash like
feature/123. This isbecause the used pattern matching logic doesn't expect remote branch
names like
origin/feature/123.In order to solve it, the new
transformationplugin is introduced. Itprovides functions that parse remote branch names correctly. Now, the
plugin handles branch translation (mapping) for
deliver-workcommandas well as for
accept-workandobtain-workin order to preventpossible errors in the future.
#255
The contribution:
CONTRIBUTING.md > Committing the changesrulesREADME.md > Hands-on development notes@bees-hive/elegant-git-maintainers, please review.