Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AcquireRepository will configure gpg signature #301

Merged
merged 2 commits into from
Apr 5, 2023
Merged

AcquireRepository will configure gpg signature #301

merged 2 commits into from
Apr 5, 2023

Conversation

teggotic
Copy link
Contributor

@teggotic teggotic commented Mar 4, 2023

Port gpg signature logic from bash implementation.

#297

@teggotic teggotic requested a review from extsoft March 4, 2023 00:14
@teggotic teggotic force-pushed the 297-1 branch 5 times, most recently from d09a2c0 to 9165e6f Compare March 12, 2023 18:07
Base automatically changed from 299 to main March 15, 2023 02:26
@extsoft
Copy link
Contributor

extsoft commented Mar 15, 2023

@teggotic please resolve conflicts.

Port gpg signature logic from bash implementation.

#297
`type` command is only available as the shell command which means that
we can't use `proc`. This means we should use `shell` instead.
However, using `shell` is not safe, and escaping is needed to make sure
args are mungled. This is the reason why I use `shell` only for `type`
command and `proc` for everything else.

#297
Copy link
Contributor

@extsoft extsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teggotic great work!

@extsoft extsoft merged commit 7eceabc into main Apr 5, 2023
@extsoft extsoft deleted the 297-1 branch April 5, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants