[DEFERRED] Adding credit channels to channel tunnel #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpetrisko
force-pushed
the
channel_tunnel_credit_channels
branch
from
0e6b638
to
a48961d
Compare
dpetrisko
changed the title
dpetrisko
force-pushed
the
channel_tunnel_credit_channels
branch
from
a48961d
to
a5d9120
Compare
dpetrisko
changed the title
|
Discussed offline to defer. Interesting improvement would be to serialize the split credit channel to reduce the CT arbitration logic |
dpetrisko
changed the title
dpetrisko
pushed a commit
that referenced
this pull request
Jan 26, 2023
* Remove/replace printf * make SPMD loader print once every 1024 packets when !verbose_p
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to have credit channels to the channel tunnel. This is necessary in the case of tunneling a large number of channels over a narrow channel with a large number of credits.
Ignore the testbench changes, will update Makefile.sim to use VCS before merging