bsg_mem_1r1w_one_hot_write_mask_bit/byte #662
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicoLi424
changed the title
dpetrisko
reviewed
Sep 4, 2023
|
|
||
| logic [width_p-1:0] data_n; | ||
|
|
||
| bsg_encode_one_hot #(.width_p(safe_els_lp) |
There was a problem hiding this comment.
don't need the encoder here, the enable signal in the mem_array for loop will handle the selection. We can just nest the write mask loop in the mem_array loop
dpetrisko
reviewed
Sep 4, 2023
| (.i(w_mask_i) | ||
| ,.o(w_mask_expanded_lo) | ||
| ); | ||
|
|
There was a problem hiding this comment.
Preferred to use this strategy of replicating non-masked rams: https://github.com/bespoke-silicon-group/basejump_stl/blob/master/bsg_mem/bsg_mem_1r1w_sync_mask_write_byte_synth.v
RicoLi424
force-pushed
the
bsg_mem_one_hot_mask
branch
from
71c9b7a
to
8ce5dd6
Compare
|
Used the previously unused reset input port in bsg_mem_1r1w_one_hot and bsg_mem_1r1w_one_hot_mask_write_bit/byte |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add write mask bit/byte feature to 1r1w one hot mem