Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DirichletAlleleDepthAndFraction test to not modify it's expected results. #7563

Closed
wants to merge 2 commits into from

Conversation

cmnbroad
Copy link
Collaborator

No description provided.

@cmnbroad cmnbroad requested a review from vruano November 15, 2021 15:18
@cmnbroad cmnbroad changed the title Fix DirichletAlleleDepthAndFraction test to not modify it's own inputs. Fix DirichletAlleleDepthAndFraction test to not modify it's expected results. Nov 15, 2021
@cmnbroad
Copy link
Collaborator Author

cmnbroad commented Nov 22, 2021

Rebased on current master, and added a second commit to reflect the new test results that are presumably related to #7394. I assume that the original issue (overwriting the expected results) masked the fact that these test results changed when the tests were run for #7394.

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #7563 (8c5365b) into master (6c6db6e) will decrease coverage by 0.001%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #7563       +/-   ##
===============================================
- Coverage     86.946%   86.945%   -0.001%     
+ Complexity     36929     36928        -1     
===============================================
  Files           2219      2219               
  Lines         173667    173668        +1     
  Branches       18755     18755               
===============================================
- Hits          150996    150995        -1     
- Misses         16057     16058        +1     
- Partials        6614      6615        +1     
Impacted Files Coverage Δ
...irichletAlleleDepthAndFractionIntegrationTest.java 100.000% <ø> (ø)
.../hellbender/utils/python/PythonUnitTestRunner.java 75.410% <0.000%> (-3.279%) ⬇️

@cmnbroad cmnbroad closed this Sep 7, 2022
@cmnbroad
Copy link
Collaborator Author

cmnbroad commented Sep 7, 2022

Closing in favor of #7963.

@cmnbroad cmnbroad deleted the cn_fix_pseudo_depth_test branch September 7, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant