Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

used _default stream instead #7588

Merged
merged 2 commits into from
Dec 1, 2021
Merged

used _default stream instead #7588

merged 2 commits into from
Dec 1, 2021

Conversation

kcibul
Copy link
Contributor

@kcibul kcibul commented Dec 1, 2021

Quick PR to use the _default stream for writing to the load_status_table since it (a) commits immediately and (b) doesn't count towards the CreateStreamWriter quota

Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kcibul kcibul merged commit 6534566 into ah_spike_writeapi Dec 1, 2021
@kcibul kcibul deleted the kc_default_stream branch December 1, 2021 22:53
ahaessly pushed a commit that referenced this pull request Dec 8, 2021
* used _default stream instead

* default to new jar
ahaessly added a commit that referenced this pull request Dec 8, 2021
* use pending BQ writer
* finalize stream before commit
* update create tables for ref ranges
* fix flushing and closing
* use python to update data model
* return error if response is not 200
* add bq table creation to assign ids, cleanup
* update import with ref_ranges as default and 40 as drop state. update docs
* fix tables for duplicate check
* create separate readme for AoU Gvs workspace
* handle null vet and pet creator
* add initial test for write api
* added sample_load_status table creation
* log load status and verify sample is not loaded
* used _default stream instead (#7588)
* safety checks for restarts via preemptibles (#7590)
* add is_loaded check back to GvsCreateFilterSet
* 3 retries and bigger machine for writeAPI ingest (#7592)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants