3 retries and bigger machine for writeAPI ingest #7592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcibul
reviewed
Dec 7, 2021
| @@ -292,7 +292,8 @@ task LoadData { | |||
| >>> | |||
| runtime { | |||
| docker: docker | |||
| memory: "3.75 GB" | |||
| maxRetries: 3 | |||
| memory: "6 GB" | |||
There was a problem hiding this comment.
Do you have reason to believe we need more memory? I didn't see this in the 2k samples (and upping the memory will double the cost)
kcibul
approved these changes
Dec 7, 2021
ahaessly
pushed a commit
that referenced
this pull request
Dec 8, 2021
ahaessly
added a commit
that referenced
this pull request
Dec 8, 2021
* use pending BQ writer * finalize stream before commit * update create tables for ref ranges * fix flushing and closing * use python to update data model * return error if response is not 200 * add bq table creation to assign ids, cleanup * update import with ref_ranges as default and 40 as drop state. update docs * fix tables for duplicate check * create separate readme for AoU Gvs workspace * handle null vet and pet creator * add initial test for write api * added sample_load_status table creation * log load status and verify sample is not loaded * used _default stream instead (#7588) * safety checks for restarts via preemptibles (#7590) * add is_loaded check back to GvsCreateFilterSet * 3 retries and bigger machine for writeAPI ingest (#7592)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.