Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to (optionally) zero pad the vcf filename. #7783

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

gbggrant
Copy link
Collaborator

This PR changes GvsExtractCallset to optionally pad the output VCFs with a leading zero. They are named in a similar fashion to the (also optionally renamed) interval list shards.

If the input zero_pad_output_vcf_filenames is set to true (the default) the VCFs and interval files will be named as such:

  • 0000000000-gg_filterset.vcf.gz
  • 0000000000-gg_filterset.vcf.gz.tbi
  • 0000000000-gg_filterset.vcf.gz.interval_list
  • 0000000001-gg_filterset.vcf.gz
  • 0000000001-gg_filterset.vcf.gz.tbi
  • 0000000001-gg_filterset.vcf.gz.interval_list
  • ...

An example workflow is here

If the input zero_pad_output_vcf_filenames is set to false, the workflow will name things as it has in the past:

  • gg_filterset_0.vcf.gz
  • gg_filterset_0.vcf.gz.tbi
  • 0000000000-scattered.interval_list
  • gg_filterset_1.vcf.gz
  • gg_filterset_1.vcf.gz.tbi
  • 0000000001-scattered.interval_list
  • ...

An example workflow is here

Copy link
Collaborator

@mcovarr mcovarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Also (optionally) change the naming of the intervals file to match that of the VCFs
@gatk-bot
Copy link

gatk-bot commented Apr 19, 2022

Travis reported job failures from build 38951
Failures in the following jobs:

Test Type JDK Job ID Logs
conda openjdk8 38951.5 logs
conda openjdk8 38951.5 logs

@gbggrant gbggrant merged commit 3ff95df into ah_var_store Apr 19, 2022
@gbggrant gbggrant deleted the gg_VS-373_ZeroPadVcfNames branch April 19, 2022 16:00
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants