Update to latest version of ah_var_store gatk override jar #7793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcovarr
reviewed
Apr 20, 2022
| @@ -14,7 +14,7 @@ workflow GvsCreateFilterSet { | |||
| Array[String] snp_recalibration_annotation_values = ["AS_QD", "AS_MQRankSum", "AS_ReadPosRankSum", "AS_FS", "AS_MQ", "AS_SOR"] | |||
|
|
|||
| File interval_list = "gs://gcp-public-data--broad-references/hg38/v0/wgs_calling_regions.hg38.noCentromeres.noTelomeres.interval_list" | |||
| File gatk_override = "gs://broad-dsp-spec-ops/scratch/bigquery-jointcalling/jars/ah_var_store_20220406/gatk-package-4.2.0.0-480-gb62026a-SNAPSHOT-local.jar" | |||
| File gatk_override = "gs://broad-dsp-spec-ops/scratch/bigquery-jointcalling/jars/ah_var_store_20220415/gatk-package-4.2.0.0-492-g1387d47-SNAPSHOT-local.jar" | |||
There was a problem hiding this comment.
this is at least a couple of revisions back now so it wouldn't be picking up the zero-padding improvements from #7783
There was a problem hiding this comment.
True - I'll rebuild it - but the only gatk jar improvements in 7783 were really just cleaning up some logging.
There was a problem hiding this comment.
oh yeah you're right... wow did I misremember that code 😅
There was a problem hiding this comment.
in an ideal world, I think we would also create these ahead of our releases and have one named for the release---so we'd have a Charlie jar (though we've re-made it a few times over the last few weeks....)
mcovarr
approved these changes
Apr 20, 2022
RoriCremer
approved these changes
Apr 20, 2022
gbggrant
force-pushed
the
gg_RestoreRscriptConditionally
branch
from
b5ef520
to
3dd04f3
Compare
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.