Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cromwell and womtool from v51 to v59. #7824

Closed
wants to merge 1 commit into from

Conversation

cmnbroad
Copy link
Collaborator

@cmnbroad cmnbroad commented May 2, 2022

Update cromwell and womtool. See if I feel lucky.

@cmnbroad cmnbroad marked this pull request as draft May 2, 2022 19:14
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #7824 (d5011db) into master (72684d0) will increase coverage by 0.006%.
The diff coverage is n/a.

❗ Current head d5011db differs from pull request most recent head ed1faba. Consider uploading reports for the commit ed1faba to get more accurate results

@@               Coverage Diff               @@
##              master     #7824       +/-   ##
===============================================
+ Coverage     86.948%   86.954%   +0.006%     
+ Complexity     36927     36897       -30     
===============================================
  Files           2219      2214        -5     
  Lines         173673    173540      -133     
  Branches       18755     18736       -19     
===============================================
- Hits          151006    150900      -106     
+ Misses         16055     16039       -16     
+ Partials        6612      6601       -11     
Impacted Files Coverage Δ
.../hellbender/utils/python/PythonUnitTestRunner.java 75.410% <0.000%> (-3.279%) ⬇️
...roadinstitute/hellbender/utils/read/ReadUtils.java 81.646% <0.000%> (-0.633%) ⬇️
...tute/hellbender/engine/AssemblyRegionIterator.java 92.632% <0.000%> (-0.152%) ⬇️
...ples/ExampleMultiFeatureWalkerIntegrationTest.java 91.566% <0.000%> (-0.100%) ⬇️
...broadinstitute/hellbender/utils/read/GATKRead.java 57.377% <0.000%> (ø)
...titute/hellbender/tools/walkers/sv/SVAnnotate.java 98.701% <0.000%> (ø)
.../hellbender/tools/walkers/GenotypeGVCFsEngine.java 90.826% <0.000%> (ø)
...notyper/GenotypeCalculationArgumentCollection.java 89.474% <0.000%> (ø)
...otypecaller/HaplotypeCallerArgumentCollection.java 100.000% <0.000%> (ø)
...typecaller/LikelihoodEngineArgumentCollection.java 100.000% <0.000%> (ø)
... and 9 more

@mcovarr
Copy link
Collaborator

mcovarr commented May 3, 2022

Cromwell switched to Java 11 starting with version 60 so the Java 8 sub-builds are probably going to error like

Caused by: java.lang.UnsupportedClassVersionError: wdl/draft3/parser/WdlParser$Ast has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0
	at java.lang.ClassLoader.defineClass1(Native Method)
	at java.lang.ClassLoader.defineClass(ClassLoader.java:756)
	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
	at java.net.URLClassLoader.defineClass(URLClassLoader.java:473)

@cmnbroad
Copy link
Collaborator Author

cmnbroad commented May 3, 2022

@mcovarr Ouch. Well, thanks for the update - I guess we'll add that to the long list of reasons to move off of Java 8.

@cmnbroad cmnbroad changed the title Update cromwell and womtool from v51 to v78. Update cromwell and womtool from v51 to v59. May 16, 2022
@cmnbroad cmnbroad marked this pull request as ready for review May 16, 2022 14:14
@cmnbroad
Copy link
Collaborator Author

Closing in favor of #8035.

@cmnbroad cmnbroad closed this Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants