Volatile tasks review [VS-447] #7880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ah_var_store #7880 +/- ##
================================================
Coverage ? 86.290%
Complexity ? 35190
================================================
Files ? 2170
Lines ? 164888
Branches ? 17786
================================================
Hits ? 142282
Misses ? 16281
Partials ? 6325 |
mcovarr
force-pushed
the
vs_447_volatile_tasks_review
branch
2 times, most recently
from
7498550
to
4ec9b34
Compare
mcovarr
force-pushed
the
vs_447_volatile_tasks_review
branch
from
533d0fa
to
12eb7a1
Compare
RoriCremer
reviewed
Jun 8, 2022
| fq_sample_table = fq_sample_table, | ||
| sample_table_timestamp = SamplesTableDatetimeCheck.last_modified_timestamp, | ||
| intervals = SplitIntervals.interval_files[i], | ||
| fq_alt_allele_table = fq_alt_allele_table, |
There was a problem hiding this comment.
not in the scope of this pr, but why do we need the fq alt allele table if we know the project and dataset? will alt allele tables ever be somewhere else?
There was a problem hiding this comment.
Not sure. This code is quite old by GVS standards (> 1.5 years), assumptions may have been different back then?
RoriCremer
approved these changes
Jun 8, 2022
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for mobbing discussionReady for review, integration tested here.