Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mutect3 dataset generation to Mutect2 WDL #7992

Merged
merged 10 commits into from
Aug 18, 2022
Merged

Conversation

davidbenjamin
Copy link
Contributor

In addition, this PR removes Funcotator (these workflows don't need to be coupled),a bunch of code that juggles file names, and some obsolete and clunky means of handling defaults from the Mutect2 WDL. Also, it deletes the mutect2 multi-sample WDL which Terra renders unnecessary.

@takutosato Do you have time for one last code review?

Copy link
Contributor

@takutosato takutosato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup looks good!

@davidbenjamin
Copy link
Contributor Author

Thanks! I'll just fix the womtool failure on the pon WDL now.

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #7992 (efd6394) into master (05a7634) will increase coverage by 7.358%.
The diff coverage is 50.000%.

@@               Coverage Diff               @@
##              master     #7992       +/-   ##
===============================================
+ Coverage     79.301%   86.659%   +7.358%     
- Complexity     36613     38769     +2156     
===============================================
  Files           2328      2328               
  Lines         181684    181685        +1     
  Branches       19950     19952        +2     
===============================================
+ Hits          144077    157447    +13370     
+ Misses         30805     17240    -13565     
- Partials        6802      6998      +196     
Impacted Files Coverage Δ
...er/tools/walkers/annotator/AssemblyComplexity.java 97.333% <50.000%> (-1.315%) ⬇️
...tools/walkers/rnaseq/GeneExpressionEvaluation.java 89.286% <0.000%> (+0.397%) ⬆️
...llbender/tools/spark/sv/evidence/ReadMetadata.java 88.480% <0.000%> (+0.490%) ⬆️
.../walkers/vqsr/CNNScoreVariantsIntegrationTest.java 96.629% <0.000%> (+0.562%) ⬆️
...tmutpileup/ValidateBasicSomaticShortMutations.java 79.570% <0.000%> (+1.075%) ⬆️
...dinstitute/hellbender/tools/sv/SiteDepthtoBAF.java 82.418% <0.000%> (+1.099%) ⬆️
...lkers/validation/EvaluateInfoFieldConcordance.java 72.581% <0.000%> (+1.613%) ⬆️
...va/org/broadinstitute/hellbender/GATKBaseTest.java 98.333% <0.000%> (+1.667%) ⬆️
...kers/variantutils/UpdateVCFSequenceDictionary.java 86.207% <0.000%> (+1.724%) ⬆️
...ute/hellbender/tools/sv/CondenseDepthEvidence.java 80.488% <0.000%> (+2.439%) ⬆️
... and 208 more

@davidbenjamin davidbenjamin merged commit c28e244 into master Aug 18, 2022
@davidbenjamin davidbenjamin deleted the db_mutect_wdl branch August 18, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants