Ultima.flow annotations.fix #8442
Conversation
|
@dror27 - can you remind me what we decided to do with this fix? I kind of remember that we decided to not change the definition... But I may be confused |
@ilyasoifer I believe that this has to "simply" be merged. |
|
Is it possible to add an integration test to this? Since the change did not fail any test, it seems that the integrationtest is missing |
Unit test fixed to include checking of variant type (which it did not include before - hence the non-failure). Test data adjusted accordingly. |
|
@meganshand - this is the first PR in the series. PTAL, thanks! |
* hmer ondel must have mon length * Revert "hmer ondel must have mon length" This reverts commit 7852871. * remove superfluous variant type condition * fix error message to actually reflect missing argument * fixed unittest to include variant type * Remove conflict
minor changes and fixes to Flow Annotations.