Fix what looks like a bug in FlowBasedRead #8576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* also make the logger static so you're not allocating a new one for every read
|
Github actions tests reported job failures from actions build 6789554372
|
|
@lbergelson you are right. This check is anyway obsolete. I will submit a separate PR that deletes this check altogether. I suggest to close this PR for now |
|
Thanks @ilyasoifer. I'll close this one. I wasn't sure what the effect was, just saw that it looked wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ilyasoifer I noticed this method wasn't doing anything, it looks like it should have a return here.
Also, I made the logger static because it's probably expensive to allocate one for every read and you don't need to.