-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the GATK base image to a newer LTS ubuntu release #8610
Changes from 11 commits
d8fe231
50cfd0b
4a4b5c6
59762d5
87d6706
ccaea7c
2187cf2
5576927
636d139
5934691
82e8bfb
312141b
92ce8ac
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
#!/bin/bash | ||
|
||
if [ $# -ne 1 ]; then | ||
echo "Usage: $0 docker_image_version" | ||
exit 1 | ||
fi | ||
|
||
IMAGE_VERSION=$1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I am definitely going to update the old build script before merging this, and also add a separate script to release a pre-staged base image to the official location |
||
IMAGE_NAME="us.gcr.io/broad-dsde-methods/gatk-base-image-staging-area" | ||
DOCKER_IMAGE_TAG="${IMAGE_NAME}:${IMAGE_VERSION}" | ||
|
||
gcloud builds submit --tag ${DOCKER_IMAGE_TAG} --timeout=24h --machine-type n1_highcpu_32 | ||
|
||
if [ $? -ne 0 ]; then | ||
echo "gcloud builds submit failed" | ||
exit 1 | ||
fi | ||
|
||
echo "Successfully published image to staging area at ${DOCKER_IMAGE_TAG}" | ||
exit 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this system pip required for anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it might be useful to have a pip in the base environment, but I can remove it if you think it might cause problems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine, just curious!